Download & Extend
Re: Comment subjects » Issues

disabled subjects not working after comment_update_6002

Posted by JonoB on September 11, 2009 at 3:41pm
Project:Re: Comment subjects
Version:6.x-1.4
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

If you disable the Comment subject field in Admin>Content Management>Content Types>ContentName>Comment Settings , then the module has not effect.

It should still work in my opinion.

Login or register to post comments

Comments

#1

Posted by arhak on September 13, 2009 at 11:01pm
Title:Not working with Comment subject field disabled» support comment_update_6002 (Not working with Comment subject field disabled)
Category:feature request» bug report
Status:active» needs review

since comment_update_6002 having subject disabled makes the module useless due to an out of date variable name

AttachmentSize
2009-09-13_support_comment_update_6002.patch 664 bytes

#2

Posted by arhak on September 13, 2009 at 11:50pm

a new patch which is compatible with comment_update_6002 and also preserves backward compatibility for older schema versions of comment module

AttachmentSize
2009-09-13_support_comment_update_6002_preserving_backward_compatibility.patch 881 bytes

#3

Posted by arhak on September 14, 2009 at 3:49am

@#2 sorry, I missed a line

AttachmentSize
2009-09-13_support_comment_update_6002_preserving_backward_compatibility.patch 1.01 KB

#4

Posted by arhak on November 18, 2009 at 4:26pm

this patch still needs review

#5

Posted by arhak on November 19, 2009 at 4:09am
Title:support comment_update_6002 (Not working with Comment subject field disabled)» disabled subjects not working after comment_update_6002

It seems that there is no one using 6.x-1.4 with subjects disabled,
or they might thought it wasn't intended to work with this module

nevertheless, I'm attaching now the right patch
since, patch #3 was made without rolling back patch #1 and therefore doesn't apply against any version

PS: 6.x-1.5 should be released soon with this fix committed

AttachmentSize
2009-11-18_support_comment_update_6002_preserving_backward_compatibility.patch 959 bytes

#6

Posted by arhak on November 19, 2009 at 10:51am
Status:needs review» fixed

released 6.x-1.5 with this fixed

#7

Posted by arhak on December 1, 2009 at 5:28am
Status:fixed» closed (fixed)

almost two weeks now, I'm closing it to clean up the issue queue