why is this code not working? want to make one of two fields on node form required

By sylvie_n on 11 Sep 2009 at 16:02 UTC

Hi guys,
wondering if you could help me figure out why my following custom module code isn't working. I am trying to make it so that one of two fields is required on a node form. I know for sure that the second function is being called, but not working as i want:

function required_form_alter(&$form, $form_state, $form_id){
if($form_id == 'job_classified_node_form'){
$form['#validate'][] = 'required_mysubmit';
  }
}

function required_mysubmit(&$form, $form_state) {
drupal_set_message('Form fields: ' . implode(', ',  array_keys($form_state['values'])));
  if (($form_state['values']['field_email_address']== '')&&($form_state['values']['field_phone_number']== '')){
      form_set_error('required', t('Please enter in an email address.'));

  }
}

The problem lies in the following:

 if (($form_state['values']['field_email_address']== '')&&($form_state['values']['field_phone_number']== '')){
      form_set_error('required', t('Please enter in an email address or phone number.'));

Any suggestions?

Comments

whats the error that comes back?

playwithtoy commented 11 September 2009 at 16:55

what happens or doesnt happen?

you can try putting an else statement that returns the values so you can see what the if is testing

hi there. thanks for your

sylvie_n commented 11 September 2009 at 19:26

hi there.
thanks for your response.
There is no error, it just doesn't return anything.
When I include:

else {form_set_error('required', t('Please enter in an email address.')); }
It prints the message "Please enter in an email address"
So the function is being called correctly, it just isn't TRUE.

I tried including:
else {return $form_state['values']['field_email_address'];}

This also doesn't produce anything. Have I got the code right here?
Thanks

try this

playwithtoy commented 11 September 2009 at 22:09

else {
form_set_error('else error=', $form_state['values']['field_email_address']);
}

but if its passing the if test

if (($form_state['values']['field_email_address']== '')&&($form_state['values']['field_phone_number']== '')){
      form_set_error('required', t('Please enter in an email address or phone number.'));

that means that
both $form_state['values']['field_email_address'] and $form_state['values']['field_phone_number']
are
1) empty or
2) you are looking trying to access the form_state array improperly
are you sure that the $form_state array is set up the way you are travelling down it?

hey, i was writing the array

sylvie_n commented 14 September 2009 at 15:56

hey,
i was writing the array improperly. it is ['field_email_address']['value']
However, it doesn't produce anything using else {
form_set_error('else error=', $form_state['field_email_address']['value']);
even though I can see on the print out of the array that it does have a value (if you look at the below, you can see [value] => zdczx).

However, I'm not sure how far i should be writing down the array.
the array prints out as follows:
Array
(
[title] => Array
(
[#type] => textfield
[#title] => Classified Ad Title
[#required] => 1
[#default_value] =>
[#maxlength] => 255
[#weight] => -5
[#post] => Array
(
[title] =>
[taxonomy] => Array
(
[2] =>
)

[menu] => Array
(
[link_title] =>
[parent] => primary-links:0
[weight] => 0
)

[teaser_include] => 1
[body] =>
[format] => 1
[changed] =>
[op] => Save
[form_build_id] => form-c0e1cb91eae914a1be7900041d6fe34e
[form_token] => 2777b3b516c5d704b053af340cc3dbd2
[form_id] => job_classified_node_form
[log] =>
[name] => bebecohete
[date] =>
[status] => 1
[promote] => 1
[path] =>
[comment] => 2
[field_email_address] => Array
(
[0] => Array
(
[value] => zdczx
)

)

[field_phone_number] => Array
(
[0] => Array
(
[value] => 89789
)

)

}

can you see how much of this i should be following down?
thanks

getting to the 'value' in the email address field array

sylvie_n commented 14 September 2009 at 20:42

When i enter in:

 else {
form_set_error('else error=', $form_state['values']['field_email_address']);
}

it prints out 'Array' as the error message.

However, when i enter in

 else {
form_set_error('else error=', $form_state['values']['body']);
}

it prints out the correct body value as the error message.

I need to get to the ['value'] within the field_email_address array.
However, when i enter in

 else {
form_set_error('else error=', $form_state['values']['field_email_address']['value']);
}

it doesn't show anything

try printing this out

playwithtoy commented 15 September 2009 at 01:16

print $form_state['field_email_address'][0]['value'];

hey! thanks. But that doesn't

sylvie_n commented 15 September 2009 at 14:13

hey!
thanks. But that doesn't print out anything...

ok - we have to go a bit slower then

playwithtoy commented 16 September 2009 at 00:13

what array are you printing out up there?
is it $form_state

if it is
what happens when u do a print_r($form_state["field_email_address"]);

Hi! The array I am copying

sylvie_n commented 18 September 2009 at 21:27

Hi!
The array I am copying from is:
print_r($form);

print_r($form_state["field_email_address"]); doesn't print out anything.
Neither does print_r($form_state["field_email_address"]);

ok then try this

playwithtoy commented 20 September 2009 at 03:40

print_r ($form['field_email_address'][0]['value']);

Hey, when I have the email

sylvie_n commented 21 September 2009 at 22:08

Hey,
when I have the email address field filled in as: email@hotmail.com, the following array is printed:

Array ( [#type] => textfield [#default_value] => email@hotmail.com [#autocomplete_path] => [#size] => 60 [#attributes] => Array ( [class] => text ) [#title] => email address [#description] => [#required] => [#field_name] => field_email_address [#type_name] => job_classified [#delta] => 0 [#columns] => Array ( [0] => value ) [#maxlength] => [#post] => Array ( [title] => [taxonomy] => Array ( [2] => ) [menu] => Array ( [link_title] => [parent] => primary-links:0 [weight] => 0 ) [teaser_include] => 1 [body] => [format] => 1 [changed] => [op] => Save [form_build_id] => form-2af92c8ae438e108c99b7d8682225142 [form_token] => 2777b3b516c5d704b053af340cc3dbd2 [form_id] => job_classified_node_form [log] => [name] => bebecohete [date] => [status] => 1 [promote] => 1 [comment] => 2 [path] => [field_email_address] => Array ( [0] => Array ( [value] => email@hotmail.com ) ) ) [#programmed] => [#tree] => 1 [#parents] => Array ( [0] => field_email_address [1] => 0 [2] => value ) [#array_parents] => Array ( [0] => field_email_address [1] => 0 [2] => value ) [#weight] => 0 [#processed] => 1 [#input] => 1 [#process] => Array ( [0] => form_expand_ahah ) [#name] => field_email_address[0][value] [#id] => edit-field-email-address-0-value [#value] => email@hotmail.com [#needs_validation] => 1 [#defaults_loaded] => 1 [#sorted] => 1 )

thats the answer

playwithtoy commented 22 September 2009 at 00:39

if (($form['field_email_address'][0]['value']== ''))

Hi there, Thanks. But when I

sylvie_n commented 22 September 2009 at 22:49

Hi there,

Thanks. But when I tried:

  if (($form['field_email_address'][0]['value']== '')){
      form_set_error('required', t('Please enter in an email address.'));}

else {print_r ($form['field_email_address'][0]['value']); }
}

with the email address field blank, the else statement was printed, as follows:

Array ( [#type] => textfield [#default_value] => [#autocomplete_path] => [#size] => 60 [#attributes] => Array ( [class] => text ) [#title] => email address [#description] => [#required] => [#field_name] => field_email_address [#type_name] => job_classified [#delta] => 0 [#columns] => Array ( [0] => value ) [#maxlength] => [#post] => Array ( [title] => [taxonomy] => Array ( [1] => ) [menu] => Array ( [link_title] => [parent] => primary-links:0 [weight] => 0 ) [teaser_include] => 1 [body] => [format] => 1 [changed] => [op] => Save [form_build_id] => form-9c6bee535a27362e498df1cbd0cbbabd [form_token] => a4555ef2ad10760416adb76142a6743f [form_id] => job_classified_node_form [log] => [name] => bebecohete [date] => [status] => 1 [path] => [comment] => 2 [field_area] => Array ( [value] => Santo Domingo ) [field_currency_type] => Array ( [value] => ) [field_price] => Array ( [0] => Array ( [value] => ) ) [field_alternative_price] => Array ( [value] => ) [field_email_address] => Array ( [0] => Array ( [value] => ) ) ) [#programmed] => [#tree] => 1 [#parents] => Array ( [0] => field_email_address [1] => 0 [2] => value ) [#array_parents] => Array ( [0] => field_email_address [1] => 0 [2] => value ) [#weight] => 0 [#processed] => 1 [#input] => 1 [#process] => Array ( [0] => form_expand_ahah ) [#name] => field_email_address[0][value] [#id] => edit-field-email-address-0-value [#value] => [#needs_validation] => 1 [#defaults_loaded] => 1 [#sorted] => 1 )

If the above array that is printed out is equal to ($form['field_email_address'][0]['value']), then this is not the field value which we are looking for and not equal to zero...

in the else statement put

playwithtoy commented 23 September 2009 at 22:48

in the else statement put what you want
in the orig question
you jsut wanted the proper test for the if statemnt
whcih is correct now

the thing is, is the else

sylvie_n commented 24 September 2009 at 13:30

the thing is, is the else statement is being performed whether the email address field is filled in or not!

if (($form['field_email_address'][0]['value']== ''))

so if the email address field is blank, i.e. value = zero, then the else statement should not be carried out.

I want something to happen when the email address is not filled out...this isn't happening, so the if statement isn't working. The if statement is saying, "if the email field is not filled in" perform "such and such". Well, "such and such" isn't happening when the email field is blank.

What I would like to know is the if statement for "field_email_address = nothing"

thanks

Try this

netbear commented 24 September 2009 at 13:34

if ($form['field_email_address'][0]['value']== '') {
  form_error($form['field_email_address'], t('The email address is requiered'));
}

What version of drupal are you using? I'm using 6.
thanks

Strange

netbear commented 26 September 2009 at 08:23

Well, I too copied this from working site where it works correctly... drupal 6.14.
try to modify this condition this way...

if(!isset($form['field_email_address'][0]['value']) || !$form['field_email_address'][0]['value']) {

Hey, This IF statement also

sylvie_n commented 27 September 2009 at 23:23

Hey,
This IF statement also doesn't work. It prints out the else statement.
Thanks

Issue resolved

sylvie_n commented 19 October 2009 at 16:35

Hi.
I have resolved this issue.
The code I am using, which has been tested and works is:

function required_form_alter(&$form, $form_state, $form_id){
if($form_id == 'job_classified_node_form'){
$form['#validate'][] = 'required_mysubmit';
  }
}

function required_mysubmit(&$form, $form_state) {

  if (($form['#post']['field_alternative_wage']['value']== '')&&($form['#post']['field_wage'][0]['value']== '')){
      form_set_error('required', t('Please enter in a wage or an alternative wage'));}

}