Just hit the button by mistake and it disabled virtually all modules.

Would be good if there was a warning and if the button was moved to the far right rather than right next to the Save Config button.

Comments

babbage’s picture

babbage commented
Title: No warning given - disables optional core modules » Make "Disable Contrib" button harder to accidentally activate
Category: bug » feature
Priority: Normal » Minor
Status: Active » Postponed

The module provides a button that disables all contributed modules. You clicked the button, and you are reporting that it disabled all contributed modules? I'm not sure why you think this is a bug report?

If you click the button and you didn't mean to—just move off to another page or refresh the modules page without clicking the "Save Configuration" button... that way, the modules you have unticked will remain in their previously enabled state.

Finally, changed title, because unless you can provide evidence to the contrary, I think I can fairly confidently say that Contrib Toggle does not disable any core modules (required ones or optional)... it only disables contributed modules.

no_idea_yet’s picture

no_idea_yet commented

The module provides a button that disables all contributed modules. You clicked the button, and you are reporting that it disabled all contributed modules? I'm not sure why you think this is a bug report?

IMHO from a UI perspective it is a bug. A simple popup (similar to SaveGuard) asking of you're sure you want to disable contributed modules would be great or at least moving it to the other side of the page.

If you click the button and you didn't mean to—just move off to another page or refresh the modules page without clicking the "Save Configuration" button... that way, the modules you have unticked will remain in their previously enabled state.

Cool, my mistake was an itchy trigger finger - hit save a split second after hitting the wrong button.

Finally, changed title, because unless you can provide evidence to the contrary, I think I can fairly confidently say that Contrib Toggle does not disable any core modules (required ones or optional)... it only disables contributed modules.

My apologies, just tried it again on a couple of installations, but can't reproduce - was sure it happened.

BTW, thanks for a very useful module and the quick reply :)

bmwagner’s picture

bmwagner commented

I should point out that the best method is to keep this module deactivated until you are ready to use it, ie for upgrades. This is the safest method to prevent accidental clicking, and I can't see why you would want it activated during any other times.

babbage’s picture

babbage commented

bmwagner: The functionality from the module that allows you to activate and deactivate modules with dependencies on the module administration page is arguably a much more significant feature than the "Disable Contrib" button... and is the main reason for keeping it activated between upgrades.

babbage’s picture

babbage commented
Status: Postponed » Closed (duplicate)

Marking as a duplicate of #463054: Move disable contribs button... or add speedbump.