No checks done when configured for anonymous users

schildi - September 12, 2009 - 11:51
Project:http:BL
Version:5.x-2.1
Component:Code
Category:bug report
Priority:normal
Assigned:praseodym
Status:closed
Description

When configured to check requests for anonymous users "http:bl" will not check any IP address. The reason is that in line 631

if (variable_get('httpbl_check ... && $user )) {

global variable/struct "user" is always defined and the check results in TRUE.
Probably it was meant to check it the current user id is greater than 0:

... && $user-uid

See attached patch

AttachmentSize
httpbl.module-user.patch468 bytes

#1

ruharen - September 12, 2009 - 12:09
Title:No checks done when cofigured for anonymous users» No checks done when configured for anonymous users
Category:task» bug report

Atachment is not working. Also, this is a bug.

#2

praseodym - September 12, 2009 - 12:28
Assigned to:Anonymous» praseodym

I'll have to see if I can update the 5.x branch. I think a check for "$user->uid > 0" instead of just "$user" should suffice.

#3

praseodym - September 12, 2009 - 14:30
Status:active» fixed

A new release package should be ready in a few minutes.

#4

System Message - September 26, 2009 - 14:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.