Malformed table

borfast - September 12, 2009 - 12:19
Project:Taxonomy Image
Version:6.x-1.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:borfast
Status:needs review
Description

The table in the Taxonomy image overview page is malformed. Basically it has to do with the number of columns, which is not consistent across rows. See attached images.

AttachmentSize
bad-table.png60.9 KB
fixed-table.png61.25 KB

#1

borfast - September 12, 2009 - 12:23
Status:active» needs review

This patch fixes the malformed table.

AttachmentSize
taxonomy_image-575500.patch 1.18 KB

#2

borfast - September 12, 2009 - 16:24

This one also removes the align="center" from the node types and image columns, which was looking quite weird - besides, formatting should be left for CSS instead of forced in HTML.

AttachmentSize
taxonomy_image-575500.patch 1.32 KB

#3

borfast - September 12, 2009 - 16:27

And another one that also adds "none selected" to the table when a vocabulary doesn't have any node types selected.

I have used "em" tags, although I have just submitted a patch to remove some styling elements, but I don't have the time to add CSS and redo the styling. Also, this is starting to go out of the way of the original patch, so I'll stop here. Perhaps I'll add a new ticket for this later.

AttachmentSize
taxonomy_image-575500.patch 1.37 KB
 
 

Drupal is a registered trademark of Dries Buytaert.