Download & Extend

Page-cache Lock patch

Project:Cache
Version:6.x-1.x-dev
Component:Code
Category:support request
Priority:normal
Assigned:Unassigned
Status:active

Issue Summary

Hello,

To prevent extensive locking after content refresh, I am trying to implement Page-cache Lock patch and this obviously needs Page-cache-memcache Lock patch to be translated to Cache's cache.inc include.

Then I changed this:

$cache->flush('cache_block');
$cache->flush('cache_page');

to this:
$cache->flush('cache_block');
//$cache->flush('cache_page');
// Special handling for the page cache.  Rather than flushing this table,
// we update a variable.  When pages are in high demand, this allows us to
// serve the old cached version while an updated version is being created.
variable_set('cache_page_clear', time());

manually on line 169.

Is this sane anyway? And/or is anything needed for memcache* includes under ./engines?

Thanks in advance.

Comments

#1

Memcache seems to work properly after the patch as before, but I am not sure if this could cause stale objects by the way.

Edit:On a second look, there's nothing to do with "Page-cache-memcache Lock" patch. Context had to be Page-cache Lock's directives for Drupal's original cache.inc in the above issue.

Sorry for confusion and double post.

#2

Another cache locking stampede protection discussion #802446: Cache stampede protection: drupal_render() and page cache

nobody click here