Refresh page cache after editing Site mission

guusbosman - September 13, 2009 - 14:55
Project:Domain Access
Version:6.x-2.0-rc9
Component:- Domain Conf
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed
Description

First off: this module is great and the implementation has been very stable so far.

This -minor- bug is as follows. If you set up 2 domains, and page caching is active for anonymous users, and you then change the Site mission for a domain (/admin/build/domain/conf/2), the page cache is not automatically refreshed. Anonymous users will still see the old Site mission.

The moment the admin makes another change (for example, editing a block admin/build/block/configure/block/), the page cache does get cleaned and anonymous users see the new block and Site mission.

I believe there's an API hook to call to 'drop cache' or 'refresh cache' function; this could be added to the domain/conf implementation.

#1

agentrickard - September 13, 2009 - 15:11

cache_clear_all().

I suppose we have to fire that whenever Domain Conf forms are saved. Or you could just note that it happens. I wonder what happens when the default form is saved?

And the answer is that system_settings_form_submit() clears the cache, so I suppose we should, too, on both configuration and batch editing forms.

#2

agentrickard - October 11, 2009 - 14:19
Status:active» patch (to be ported)

Nice catch. Committed. Could use a backport.

I also clear the cache on similar operations, like adding new aliases, editing themes, and the like.

AttachmentSize
576116-cache-clear.patch 4.24 KB

#3

agentrickard - October 31, 2009 - 19:28
Status:patch (to be ported)» fixed

Committed to D5.

AttachmentSize
576116-cache.patch 4.29 KB

#4

System Message - November 14, 2009 - 19:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.