Context sensitive translation issues
hass - September 13, 2009 - 14:55
| Project: | Smileys |
| Version: | 6.x-1.0-alpha5 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Description
The module is full of context sensitive translation issues. Never use l() if a link is added to a string, please! The below is only ONE example out of many that needs to be fixed.
Wrong:
<?php
$msg = t('No smileys found. You may !add, or !import.', array('!add' => l(t('add a custom smileys'), 'admin/settings/smileys/add'), '!import' => l(t('import smiley packages'), 'admin/settings/smileys/import')));
?>Correct:
<?php
$msg = t('No smileys found. You may <a href="@add-url">add a custom smiley</a>, or <a href="@import-url">import smiley packages</a>.', array('@add-url' => url('admin/settings/smileys/add'), '@import-url' => url('admin/settings/smileys/import')));
?>