Make the machine-name generation pluggeable

That's why there is an "edit" link to alter the auto-generated machine-readable name.

And. For multilingual sites, the best practice is to use English labels/titles anyway, so you can properly localize/translate them -- which means that the machine-readable name can be properly generated via the existing JS.

Hi!
I posted the same issue - #646466: Machine name generating not correctly for languages other than English
maybe we can make a check in JS file - if transliteration module is present - make AJAX call to it?

@xslim: that's an excellent idea.

errrr. We're talking JavaScript here. Transliteration module can replace the entire behavior or even the entire .js file.

so we need to make a patch to transliteration ?

Yes.

Erm. No! It's not because it's javascript that we should promote sloppy programming practices. We need to abstract the crappy regexp that is currently in *two places* of Drupal.behaviors.machineReadableValue to a separate function that Transliteration will be able to replace.

And yes, we need to do it before releasing D7.

We can add additional function like transliterate() which can be overridden by transliteration module?

Here.

I like this idea but should the translate function live at Drupal.behaviors.machineReadableValue.attach.transliterate? Or, is another location more appropriate?

+++ modules/system/system.js
@@ -207,6 +208,11 @@ Drupal.behaviors.machineReadableValue = {
+  transliterate: function(source, settings) {

1) Custom methods should have JSDoc to explain them.

2) Missing space after function.

Powered by Dreditor.

Fixed the issues raised by sun.

@mfer: the function is at Drupal.behaviors.machineReadableValue.transliterate(), which makes sense to me.

Thanks!

Seems like a reasonable improvement. It does not cause Drupal to cease to function, and therefore is not critical.

Committed to HEAD.