Supporting Views Calc

Did this patch get committed? I have a bunch of failures when trying to run patch against current (as of today) 6.x-1.x-dev... And after patch was run, tons of errors in any views_calc view. Because I'm an idiot, I didn't attempt to just use dev and see if it was in there...

web3@web2:~/web/sites/all/modules/views_customfield$ patch -p0 < views_calc.patch
patching file views_customfield.views.inc
Hunk #1 FAILED at 68.
1 out of 1 hunk FAILED -- saving rejects to file views_customfield.views.inc.rej
patching file includes/views_customfield_calc_table.inc
patching file includes/views_customfield_handler_field_phpcode.inc
Hunk #1 FAILED at 26.
Hunk #2 succeeded at 33 with fuzz 2 (offset -8 lines).
Hunk #3 FAILED at 133.
Hunk #4 succeeded at 80 (offset -91 lines).
Hunk #5 succeeded at 93 (offset -91 lines).
Hunk #6 FAILED at 109.
3 out of 6 hunks FAILED -- saving rejects to file includes/views_customfield_handler_field_phpcode.inc.rej

I'm heading out of office now, but would be happy to test further when I get back this afternoon.

OK - back in office. I'm officially an idiot - everything is functional. However, I'm getting an odd MYSQL warning:

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: SELECT nid FROM comments WHERE cid= in /var/www/clients/client1/web3/web/sites/all/modules/views_customfield/includes/views_customfield_handler_field_phpcode.inc(205) : eval()'d code on line 2.

When my computed field is running the php:

<?php
$a = db_result(db_query("SELECT nid FROM comments WHERE cid=" . $data->cid));
$b = db_result(db_query("SELECT case_type_id FROM casetracker_case WHERE nid=" . $a));
$c = db_result(db_query("SELECT case_state_name FROM casetracker_case_states WHERE csid=" . $b));
print $c;
?>

This happens everywhere else that $data->cid is called (many different views custom fields), but they all DO produce the expected output, so $data->cid is obviously not returning null, as the SQL warning seems to suggest.

Thoughts?

Hehe... I know nothing about databases, but if you wanted to help me w/ the joins... :)

The table actually shows the correct data, which makes the warnings even stranger.

Will confirm ASAP, probably tomorrow though. Thanks for the help w/ JOIN! Maybe I should actually learn how to make an efficient SQL query some day :)

Apologies for delay - this patch works great against current -dev.

subscribing

subscribing

Subscribing.

I am trying this patch. However, I get this error on my testing environment. What went wrong?

user warning: Unknown column 'customfield.phpcode' in 'field list' query: SELECT MAX('') AS node_created, MAX('COUNT') AS TOTAL_COUNT, MAX('') AS nid, COUNT(node.title) AS node_title, COUNT(customfield.phpcode) AS customfield_phpcode_3 FROM node node WHERE node.type in ('activitystream') in 

I see no customfield table on my mysql database.

Sorry, my bad. I didn't read the instruction. I selected "Views Custom Field Calc Table", then all is fine now.

subscribing

Hi,
Strange behavior here. I successfully applied the patch to the latest dev version. When I go edit the style format, I can see the new "Views Custom Field Calc Table" option. I select it. Update. But it won't stick. It always reverts back to previous selection (eg. Views Calc Table). Any ideas here?

Mike

i can confirm this works, you need views_calc stable-6.x-1.3 and the views_customfield-6.x-1.x-dev with the patch in #1 applied
besides the steps outline in the original post above, you might also need to edit your customfields, and separate the actual value from the formatted output for this to work (for eg. im outputting prices, and i needed to take the '$' out of the actual value)

with latest views_calc -DEV:
PHP Fatal error: Cannot use object of type stdClass as array in sites/all/modules/views_customfield/includes/views_customfield_calc_table.inc on line 14

i attached a re-roll of the patch because #1 applied with fuzz

im actually hitting this item in the patch:

    // TODO This won't work right with relationships, need a fix here.
    if (!empty($this->view->views_calc_nids)) {
      $this->view->query->add_where(NULL, "node.nid IN (%s)", implode(',', $this->view->views_calc_nids));
    }

if i comment it out, i dont get this error in the logs and everything seems fine:

"You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ',,,,,,,,,,,,,,,,,,,,,,,,,,)))... i have this in the sql that gives the error "AND (node.nid IN (,,,,,,,,,,,,,,,,,,,,,,,,,,,)))"

@infojunkie, any hints on what would be needed for the TODO item?

Hi,
Thanks for this great module and this patch.
In my view, the total SUM doesn't display if equal to 0.
Any idea how to display 0 ?

Thanks for any help.

Greetings,

I am having the same issue as #15, I successfully applied the patch in #1, then when I select the "Views Custom Field Calc Table" option it reverts to the previous selection.

Any insight into what may be the issue here would be appreciated.

Thanks in advance.

Scott

I installed the patch and now I can see the new style option in the views. But no calculation is made, namely all calculation rows are blank/empty. "Views calc" computes correctly though. By the way, I don't get any error when selecting a customfield, which I did with "Views Calc Table". Do you have any idea what might go wrong?

Subscribing

This patch worked perfectly for me against the dev version, I recommend this patch be committed into the module.

Did you ever figure this out? I'm having this same issue as #15 and #19 - on drupal 6 site I'm doing some dev work on.

#16 works!!!
Views Calc 6.x-1.3
Views Custom Field 6.x-1.x-dev

Thank you!

Not committed yet?

#16 is OK.
I confirm that Views Calc DEV does not work with this patch.
I understand that this patch provides a new Views style that only works with custom fields, so one cannot mix database actual fields and computed custom field values in the same table.
I would have thought that this patch would better be part of Views Calc.