Hi,

Under what circumstances should this message appear? I am on a dev site and whilst I havnt touched a product page in a few days I keep seeing this appear (not everytime, but noticable). For example, I just added a comment and it came up.

Just want info really to know if this is right or not.

Thanks,
Paul.

Comments

torgospizza’s picture

Hi, no, it's not supposed to do this. It was brought up in another thread... I think I'll need to release a new stable just to patch this error. It's really just one line of code that needs to be commented out. Let me work on this, I'll create a new patch based on the current stable and then roll that into a new release.

EDIT: I just looked into the release, and 6.x-1.17 has the Upsell message commented out. Which version of the module are you using? Your Issue is for the 1.9 version of the module; you might consider upgrading. Many changes have been added (bugs fixed) since 1.9 :)

torgospizza’s picture

I just realized 1.17 is a phantom release that's probably going to get skipped over because it has some issues on its own. Let me patch the current 1.16 and I'll come up with a new 1.18 release that will include that patch. Heh... guess I gotta make sure I see what's currently in the stable release before I look through my CVS repo :)

torgospizza’s picture

Just added a 1.18 release that should solve this (but retains the functionality from 1.16...) Let me know if it works for you!

Rainman’s picture

Somehow this was missed in the 1.18 release, the drupal_set_message('Upsell term array was updated.'); is in this release not commented.

torgospizza’s picture

Ugh, you're right. I don't understand why. I committed the change and then tagged it for the new release. My working CVS copy has it commented out, but the released version didn't apparently take from that new tag. Let me look into this and see if I can straighten it out (it might mean creating a new Dev at the same time, just to be safe).

Sorry about that. Will post as soon as it's fixed.

torgospizza’s picture

Alright, version 1.19 solves the issue. I found out I had committed a branch and not the trunk... I've figured out where things went wrong and will make sure that doesnt happen again. Feel free to give it a shot and post back with your results!

Rainman’s picture

This issue is fixed in my testing with 1.19 and haven't found any others at this time!

torgospizza’s picture

Cool :) I may freeze that as the last 6.x-1.0 release and focus next on new features in a 2.0 release. Still mulling it over...

torgospizza’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.