I'll bet you $1 that the typical Drupal admin wants typical new menu items to appear in the left navigation menu, not in primary links: As highlights and having limited space, Primary links must be exceptional and planned. Navigation is the workhorse for run-of-the-mill menu items.
Therefore, the pre-selected Parent item when creating a new link should be Navigation, not Primary links.
This combined with #322703: Use on/off checkbox to enable node's menu item and #483078: Menu item name should be node title by default will make menus a really easy, "it just works" feature that will involve a single checkbox in the vast majority of cases.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | default-for-primary-links.diff | 1.2 KB | mooffie |
| #3 | navigation-as-default-menu.patch | 2.69 KB | BarisW |
Comments
Comment #1
aren cambre commentedForgot Usability tag.
Comment #2
Bojhan commentedAgreed.
Comment #3
BarisW commentedAren, attached you'll find a patch which does this. As long as Bojhan agrees, I do too :)
Comment #4
sunLooks good.
Comment #5
Bojhan commentedAgreed, this should cause more natural behavior in using Navigation.
Comment #6
sunFollow-up issue: #594660: Rename default menu names
Comment #7
dries commentedCommitted to CVS HEAD. Thanks.
Comment #8
aren cambre commentedThanks, all! Now work on #322703: Use on/off checkbox to enable node's menu item and #483078: Menu item name should be node title by default. :-)
Comment #10
mooffie commentedIt seems there was a mistake in the patch committed: the default source for the main links was set to 'navigation'. Four problems here:
1. It was probably an accidental change.
2. Ironically, this defeats the original intention, "Primary links must be exceptional and planned."
3. It contradicts the help screen, which says "The Main menu is the default source for the Main links".
4. menu.inc continues to think that, by default, the source for the main links is 'main-menu'.
Here's a patch to undo that change.
Comment #11
mooffie commentedComment #12
sun@mooffie: I think I understand the bug you found, but I'm not entirely sure, because you squeezed the actual bug report into a few words in your first sentence only. Could you clarify, please?
Comment #13
mooffie commented@sun,
Drupal has a variable, 'menu_main_links_source', that points to the menu that serves as the source for the primary links. In other words, when Drupal wants to fetch the primary links, it looks for the menu pointed at by this variable. This variable, by default, is supposed to point to the 'main-menu' menu. (This 'main-menu' is empty on a new Drupal installation.)
If you visit ?q=admin/help/menu, the help page, you'll see this summed up in the following words: "The Main menu is the default source for the Main links".
Now,
The patch that was committed says that the 'menu_main_links_source' variable should point to the 'navigation' menu by default. But it should point to 'main-menu' by default.
Comment #14
sunThanks for clarifying, moofie! So this patch seems to be correct.
Since it is based on a variable, there's nothing we could test here.
Comment #15
webchickHey, mooffie's back! :D Awesome!
Committed to HEAD.