Closed (outdated)
Project:
Editable Fields
Version:
6.x-1.2
Component:
Miscellaneous
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Sep 2009 at 15:16 UTC
Updated:
25 Nov 2016 at 23:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
markfoodyburton commentedOdd - long time ago since I looked at this code, but I think ',' means something to jQuery......
Seems to be working for other people though?
Cheers
Mark.
Comment #2
markfoodyburton commentedjanvandiepen fixed this in the 6.2 branch, however, I think this breaks text fields :-(
I _think_ this code (which dates back to a long time ago) was intended to prevent e.g. text fields being submitted accidental by pressing e.g. the return key. (The result of which is you get the XML code, which is not pretty (and not cleaver) )
When there was a ',' there, I _think_ the 'not' selector was not finding anything to not, and was therefore allowing the selection ---- Sorry - too many nots' - hope you follow.
Hence "fixing" the not, makes the selector fail to select - result - the thing actually fails...
I think the right 'fix' is to actually remove the not selector...
e.g.
$('div.editablefields', context).not('.editablefields-processed').submit(function(){
return false;
});
becomes
$('div.editablefields', context).submit(function(){
return false;
});
I've included the patch.
It would be most appreciated if somebody else could check this.....
Cheers
Mark.
Comment #3
joelpittetClosing this to triage the queue. Feel free to comment if you'd like this to be re-opened, though currently there is nobody supporting the 6.x branch.