The message about administering block should not appear when you are not allowed to administer blocks.

I am talking about this message:

The block you just created is now available on the block configuration page.

This message appear when I finished editing/creating a node that is configured to work with nodeblock.
If I do not have the permission to administer the blocks, I should not see this message.

CommentFileSizeAuthor
#3 nodeblock-HEAD_node_save_message.patch1.12 KBdboulet
#1 577254.patch776 bytesroychri

Comments

roychri’s picture

roychri commented
Status: Active » Needs review
StatusFileSize
new 577254.patch776 bytes

Here is my proposed patch.

tom_o_t’s picture

tom_o_t commented
Assigned: Unassigned » tom_o_t
Status: Needs review » Reviewed & tested by the community

Seems like a good idea to me, I agree that the message shouldn't show if the user doesn't have permission to administer blocks.

dboulet’s picture

dboulet commented
Title: Do not display links to unaccessible pages. » Only show 'The block you just created...' message when appropriate
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new nodeblock-HEAD_node_save_message.patch1.12 KB

New patch fixes one small codestyle issue, plus moves the message into the 'insert' case, so that it's only displayed when a node is created.

Shven’s picture

Shven commented

issue still persists in v7.x.-1.2

Johnny vd Laar’s picture

Johnny vd Laar commented
Version: 6.x-1.2 » 7.x-1.x-dev

I will only do feature request for d7. D6 is in maintenance only.

Johnny vd Laar’s picture

Johnny vd Laar commented
Status: Needs review » Fixed

Committed a fix: http://drupalcode.org/project/nodeblock.git/commit/2b3824b

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.