Prevent feature from adding itself as a dependency

The reason features was added as dependency is that it implements some of the components. So if for example you have chosen CCK fields, or access permissions, then feature is indeed required.

I think what drifter meant is that the feature module (like myblog_feature) was added as a dependency by accident to myblog_feature.

As much as I think infinite recursion is a fitting punishment for this kind of #buildfail, we can definitely protect against this : )

Got it http://drupal.org/cvs?commit=304980

Couldn't find this on rc1, the bug exists again. I'm kind of using a lot of stuff from contrib modules, but I don't think it should EVER be possible for a module to be added as dependency of itself, as it causes a lot of trouble

I removed components on the interface, one by one, and the dependency is added when adding a content type that is already on the feature. Well, this never happened before, so I'm puzzled, but what happens is that after adding the dependency it naturally considers the component (the node type) as provided by dependency, and it is not exported anymore.

Would you mind attaching a tarball of the feature in question? Might help debug.

Fix for this has been committed:

http://drupal.org/cvs?commit=410086
http://drupal.org/cvs?commit=410088

Would like your confirmation before closing.

I'm not sure if I can. Also, the feature has way too many components from all kinds and there are other buggy things on it.

For instance, one of the troubles is about using workflow. I've worked on the patches to add features support to it, but someone reverted the module on our repo, and in the meanwhile I updated the feature and so the workflow element was lost. When I got the workflow patches again, the workflow on the database had a "module" column pointing to my feature, and again when adding the element, features added the own feature as dependency and the workflow element as "provided by dependecy". And the workflow element is not even on the info file anymore...

Well, I'm still trying to track the issue, but things are pretty messy after the breaking of the repo... =(

Ops, cross-posting, will check this

Applied by hand the changes, it worked!

Thanks!

Great, fix will be in the next release.