Download & Extend
Watcher » Issues

watcher css should not use !important-rule in css

Posted by osopolar on September 15, 2009 at 1:28pm
Project:Watcher
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs work

Issue Summary

I don't know why you use so much the important rule in the watcher.css but it makes styling more complicate. Please remove !important, if not really needed.

Login or register to post comments

Comments

#1

Posted by askibinski on October 15, 2009 at 9:50am

I agree.

Using !important is poor css design and should be avoided. You will make a lot of themers happy :)

#2

Posted by solipsist on October 15, 2009 at 9:55am

You can make me happy by making a patch. I am well aware of the issue but it's not something I can prioritize highly, so a patch would be help a lot.

#3

Posted by jix_ on October 15, 2009 at 9:58am
Status:active» needs review

Attached a patch. I also took the liberty of removing some whitespace and the @CHARSET declaration, which don't seem to be common to use in Drupal.

AttachmentSize
wachter-css-1.patch 3.75 KB

#4

Posted by osopolar on August 16, 2010 at 4:35pm
Status:needs review» reviewed & tested by the community

Looks good, thank you for the patch!

#5

Posted by Onyx on September 2, 2010 at 4:05am

This line 77 is wrong in pre-patched and patched:

.watcher_node_watched

should be :
background-image: url(../images/watch.gif) no-repeat

Otherwise you can click twice the under-node link and get a div full of eyeballs :D

#6

Posted by Pomliane on October 23, 2010 at 3:14pm
Status:reviewed & tested by the community» needs work
nobody click here