watcher css should not use !important-rule in css

ositoblanco - September 15, 2009 - 13:28
Project:Watcher
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs review
Description

I don't know why you use so much the important rule in the watcher.css but it makes styling more complicate. Please remove !important, if not really needed.

#1

askibinski - October 15, 2009 - 09:50

I agree.

Using !important is poor css design and should be avoided. You will make a lot of themers happy :)

#2

solipsist - October 15, 2009 - 09:55

You can make me happy by making a patch. I am well aware of the issue but it's not something I can prioritize highly, so a patch would be help a lot.

#3

mverbaar - October 15, 2009 - 09:58
Status:active» needs review

Attached a patch. I also took the liberty of removing some whitespace and the @CHARSET declaration, which don't seem to be common to use in Drupal.

AttachmentSize
wachter-css-1.patch 3.75 KB
 
 

Drupal is a registered trademark of Dries Buytaert.