Hi @all,
sorry for my bad english, this is the first time that i try to submit a patch/issue. I tried the location proximity filter in views2 but its only work when distance is set to 0. So i searched and found that the proximity filter uses the deprecated function location_latlon_rough() in location.inc - this function calls the country depended function but in some supported files like the german (location.de.inc) is the function location_latlon_rough_de() missing. One way to resolv this problem is to add the missing function or use the location_latlon_exact() function in location.inc this uses the geocoder services. So i wrote a little workaround that falls back to location_latlon_exact() when location_latlon_rough_xx() is missing.
best regards
Blackice2999
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | location-1.patch | 305 bytes | dawehner |
| location.inc_.patch | 475 bytes | blackice2999 |
Comments
Comment #1
danieldd commentedI just want to confirm that this patch completely resolved the proximity search issue for me too - thanks.
In my case I was using UK postcodes.
Also, with this patch you can effectively search against a full UK postcode (not just the first part of the code) providing the full postcode is entered without spaces.
Comment #2
timlie commentedWorks for me as well!!!!! Thanks a lot!
Belgian postcodes here!
Comment #3
danieldd commentedJust wanted to add that with this patch the proximity filter looks up places as well as postcodes.
Eg (in the case of UK) it also enables you to search for proximity to "cambridge" or "victoria station london".
I have been using the patch in a production environment for a few months.
I really hope this change has been implemented in the latest release of the module.
Comment #4
yesct commentedSomeone please compare this patch to some of the other solutions to proximity and zip code searching/filtering.
Comment #5
yesct commenteda more formal review like:
http://drupal.org/patch/review
might help the maintainer more quickly evaluate this patch. Please give a more detailed review.
Comment #6
dawehnerRemoving this line does not make sense
Powered by Dreditor.
The patch worked fine, i added the line back
Comment #7
rooby commentedThanks for the patch.
Committed to 5, 6 & 7.
http://drupal.org/cvs?commit=379198
http://drupal.org/cvs?commit=379196
http://drupal.org/cvs?commit=379200