$form["#action"] gets set to /ahah_helper/path (with patch to fix!)

I can confirm this issue and the pseudo-fix.

I'm not too familiar with forms, or how the Ahah Helper works, but should/could $form['#action'] be set and pulled from the cache?

subscribing
i have the same problem since february : http://drupal.org/node/371339

I tried to fix the problem. It seems that we should remember the initial form action before to do ahah.

Attached a patch.. It seems to work for me.

You can apply the code using the patch command like described here http://drupal.org/patch/apply.

However you can simply download and extract the ahah_helper-6.x-2.0 and put the patch into the same directory and then apply it like follow

ahah_helper$ ls
ahah_helper_action_change.patch  ahah_helper.info    README.txt
ahah_helper_demo.info            ahah_helper.js      TODO.txt
ahah_helper_demo.install         ahah_helper.module
ahah_helper_demo.module          LICENSE.txt
ahah_helper$ patch -p0 < ahah_helper_action_change.patch 
patching file ahah_helper.module

If you need an already patched version of the file let me know and i'll update this issue attaching it.

I had a problem with the patch at comment #3. It was saving the $form['#action'], but I don't want to have to explicitly set it. If there isn't an explicit #action, it should just be the $_GET['q'] when the form is first created.

Attached is an updated patch which:

• Acts as I describe above.
• Fixes some code-style problems with the original patch.

It would be wonderful if could be accepted, as this is a wide-spread problem with AHAH in drupal (see my comment on this issue: #591696: Problem with various AHAH forms and validation).

nice patch, works for me in a simple form.
i haven't tested it in form 'user_register' yet, i think this form doesn't use $form['#action'].
one question though:
will it still work if $form['#action']= 'foo'; is set AFTER ahah_helper_register($form, $form_state); ?

@boneless: That depends on what you want to happen. Do you want the new $form['#action'] = 'foo' to be the one the form is submitted to? Or do you want the original one (at the time that ahah_helper_register() was called)?

The patch will always return the $form['#action'] to the state it was the first time ahah_helper_register() was called with this instance of the form.

The previous patch breaks if the url includes a /. (i.e. forms/myform). On our server changing the $_GET['q'] to $_SERVER['REQUEST_URI'], fixes the problem (updated patch attached).

The patch works for me. Thanks!
Please consider to apply the patch to the project ASAP since I think it really cause problems.

andy
linksys e2000

I've now been running the patch in #6 for two months. Before the patch, I was constantly having problems with the form re-routing to the wrong submit page, as noted above in the original post -- but since the patch, I haven't had a single problem with this module, whatsoever.

Let's get this committed please! Let me know if there's any additional testing I can help with, but as far as I can tell, it's good to go.

Marking RTBC, since a few people including myself have tested this patch and it's worked perfectly well.
Also, marking priority critical, since the faulty submit page is, well, pretty critical. It breaks the whole form!!

It's done in 6.x-2.x-dev.

This doesn't seem to have ended up in a stable release (despite being critical and fixed over 6 months ago). It's not in 6.x-2.1. Any idea when the next stable release will pop out? :)

#10 worked for me. Glad I found this discussion.

$_SERVER['REQUEST_URI']; should actually be swapped out for http://api.drupal.org/api/drupal/includes--bootstrap.inc/function/reques...

See #591696: Problem with various AHAH forms and validation, and my core patch in #52. Please help reviewing it and testing for this problem. Chime in the core issue.

For D6, version: 6.x-2.2

If you put your Form on other file besides the .module file, after you submit your form, the

 $form_state['storage']['#ahah_helper']['file']

will disappear because ahah_helper will change your form action. I managed to workaround this by creating a new argument "external_file" in "ahah_helper_register" function:

function ahah_helper_register(&$form, &$form_state,$external_file=FALSE) {

and forced to set

 $form_state['storage']['#ahah_helper']['file']

then you need to pass the file path when you call "ahah_helper_register" in your form. For example:

function MY_MODULE_form(&$form_state){
   $file = drupal_get_path('module','MY_MODULE').'/includes/forms.inc';
   ahah_helper_register($form, $form_state,$file);   
(...)

#6 or #10 doesn't work for me... when validation fails the form action always remained as '/ahah_helper/form][path'.

My attempt also includes replacement of $SERVER['REQUEST_URI'] with as requested by greggles in #17:

  // When not set.. try to remember the old action
  if (!isset($form_state['storage']['old_action'])) {
    $form_state['storage']['old_action'] = isset($form['#action']) ? $form['#action'] : request_uri();
  }
  // If the form action is set to /ahah_helper/* path, restore the old one.
  elseif (empty($form['#action']) || strpos($form['#action'], '/ahah_helper/') !== FALSE) {
    $form['#action'] = $form_state['storage']['old_action'];
  }