Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I am using ubercart-rc3 with uc_vat, views_bonus and uc_views and working on providing a good product report in CSV for the customer. I will somehow try to collaborate with uc_views in order to expose some more that from what's currently exposed but I found the one exposed by ubercart a bit limited. While this might sound a bit custom, it's definitely more flexible, and flexibility is always good.
What I am doing is extending the price (and weight as a bonus) handlers to be a subclass of a numeric handler instead of a base handler. I also defined the data for prices and weight as float and give a nice format option to the handler (both price and weight) so you can choose to use Ubercart defaults (uc_price() and uc_weight()) or use the standard numeric render() from the stored value on the db.
This is important because if somehow I want to get the raw value from the db (without any rounding or formatting) there was no way to do that. I know I can somehow plug into the new price handler/alter logic that's been worked out but this sounded as a lot more views-like approach.
I worked the patch with rc3, but checked out the DRUPAL6--2 branch from CVS and rework it there and also test it out. Attach is patch against current CVS.
I know this is hardly a Release Blocker issue but it might be nice to have this on the final 2.0. I think a lot of uc_vat/uc_views users will appreciate it.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 578334_have_price_value_on_the_view.patch | 2.01 KB | hanoii |
| #3 | 578334_views_price_weight.patch | 6.7 KB | Island Usurper |
| #2 | uc_product_views_better_handlers.patch | 6.48 KB | hanoii |
| uc_product_views_better_handlers.patch | 6.48 KB | hanoii |
Comments
Comment #1
hanoiiComment #2
hanoiiRe-read the patch and changed a couple of words in some comment lines.
Comment #3
Island Usurper commentedThanks, hanoii. There's a lot of stuff that's available in Views that I don't know how to take advantage of everything. Committed the patch with a couple of stylistic, whitespace changes.
Comment #4
hanoiiI am glad to help. I'd like to point you to a related issue in which I'd like to hear your thoughts.
#591126: Move Views support to uc_views?
Comment #6
hanoiiI am bringing this issue back to life because I found a bug on the code. Not sure how, but there's a bit of code that went into the product's price handler that was causing the actual value of the field not to be included on the views result. On normal use of this handler (with uc_price() this wasn't a problem because the price was really taken from the loaded product rather than from the view, but when used with numeric, as I am currently using, the value was not there at all because of query() being overridden.
That bit of code was not added by my patch on this issue, but got there some other way.
Attach is a fix for that and also one more enhancement to the views price handler. When using the uc_price formatting option you now have the different revisions to choose from (altered, original, formatted, formatted-original, themed and themed-original). It's a nice and easy add-on, but the bugfix is important.
Thanks,
a.=
Comment #7
Docc commentedI can confirm the bug. Aswell that the #6 patch fixes the issue
Comment #8
Island Usurper commentedCommitted. Thanks, hanoii.
I think I must have put the query() method in there because I was going off of the add_to_cart handler instead of digging down to see what I was actually overriding.
Comment #10
hanoiiJust noting that this is a valid bug for version 2.2, as I thought it was fixed on that version. The commit happened after the release.