The generated username results in an invalid character in username error, making it impossible to sign up and create accounts when the user enters a + in her email address.

CommentFileSizeAuthor
#4 578376-uc_signup-replace-plus-username.patch905 bytescoltrane
#1 uc_signup_allow_plus_symbol.patch741 bytesrsaddington

Comments

rsaddington’s picture

rsaddington commented
StatusFileSize
new uc_signup_allow_plus_symbol.patch741 bytes

I came across this issue and added the following to uc_signup.module line 590

$namenew = str_replace('+','',$namenew);
ezra-g’s picture

ezra-g commented
Status: Active » Needs review

Marking as NR.

ezra-g’s picture

ezra-g commented
Status: Needs review » Fixed

I committed a fix that makes use of http://api.ubercart.org/api/function/uc_store_email_to_username/2 and credited you in the commit message. Sorry about the delay in getting this reviewed by thanks for your work here!

coltrane’s picture

coltrane
he/him
commented
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new 578376-uc_signup-replace-plus-username.patch905 bytes

Patch doesn't apply. rerolling using cvs diff -up

coltrane’s picture

coltrane
he/him
commented
Status: Reviewed & tested by the community » Fixed

cross post

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.