Move signup-related settings from node/N/edit to node/N/signups/settings
| Project: | Signup |
| Version: | 6.x-1.x-dev |
| Component: | User interface |
| Category: | task |
| Priority: | normal |
| Assigned: | dww |
| Status: | closed |
For a variety of reasons, it'd be nice to move all of the signup-related settings from node/N/edit to a new "Settings" sub-tab at node/N/signups/settings:
A) There are a lot of potential use-cases where a given user can admin signups on a node that they can't otherwise edit. These folks should be able to tweak signup-related settings.
B) The JS to conditionally hide/show signup-related settings when you toggle if the node is signup-enabled or not gets really complicated once other signup submodules are trying to inject their own settings, e.g. over at #359412: Move code for signup limits per status per node into a submodule.
C) It's potentially confusing UI that there are multiple places to tweak some of these settings, e.g. the global signup limit for the node.
#1
#2
FYI, here are screenies of node/N/edit when a) editing an existing signup-related node with some signups and b) a new node...
#3
Oh, and here's an example node/N/signups/settings tab
Note that I haven't fixed (C) yet by cleaning up the "Signup summary" form at the top of node/N/signups/admin
#4
Point (C) from the original post will be fixed over at #578592: Cleanup + fix the "Signup summary" at the top of node/N/signups/admin. Given that I tested this heavily during development, I committed to HEAD and DRUPAL-6--1. Folks are encouraged to test DRUPAL-6--1 ASAP and let me know if this introduced any problems so that I don't ship RC6 with any bugs in this area.
Thanks!
-Derek
#5
Forgot to include an option for the "Signup: Node: Signup link" views field...
#6
Note: for testing, you might want to apply #582626: Visibility logic for "Signup: Node: Signup link" views field is wrong to fix a bug in that views handler...
#7
Applied #582626: Visibility logic for "Signup: Node: Signup link" views field is wrong and then this patch and it resolves the issues I was experiencing.
#8
Committed to HEAD and DRUPAL-6--1. Thanks!
#9
Automatically closed -- issue fixed for 2 weeks with no activity.