Closed (fixed)
Project:
Signup
Version:
6.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
16 Sep 2009 at 00:39 UTC
Updated:
5 Oct 2009 at 05:30 UTC
Jump to comment: Most recent file
As I mentioned at #578502: Move signup-related settings from node/N/edit to node/N/signups/settings the "Signup summary" fieldset at the top of the node/N/signups/admin page is a bit weird.
A) It duplicates the setting for the signup limit (which will make life more difficult for #359412: Move code for signup limits per status per node into a submodule).
B) It's a bit of a cryptic UI (I was just trying to save space when I first laid it out).
C) It's not very easy to alter.
I'd like to fix this up before I really tear into #359412, and I want to handle it as a separate patch from #578502 -- hence, this new issue...
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 578592-2.signup_summary.patch | 6.12 KB | dww |
| #2 | 578592-2.signup_summary.png | 66.62 KB | dww |
| #1 | 578592-1.signup_summary.patch | 3.08 KB | dww |
| #1 | 578592-1.signup_summary.png | 26.68 KB | dww |
Comments
Comment #1
dwwHere's a start. Part of the complication here is that this form is (currently) shared by both node/N/signups/admin and admin/content/signup in a slightly unholy way. ;)
I'm not sure this is a vast improvement, and it doesn't yet address (C) since I'm still theming the form as a table at node/N/signups/admin, but at least it fixes (A) (instead of a text area, there's now a link to the settings subtab (with anchor to skip down to the limit setting)), and maybe improves (B).
Thoughts?
Comment #2
dwwOk, I finished everything else I've been working on in singup and signup_status land over the weekend, and came back to this. I decided to ditch the table. I'm now going with a standard form array. The theme function for this form just wraps all the elements inside their own
<div class="container-inline">so that everything is nice and compact. But this way, it's very easy to alter. I'll post a patch and screenshots to #583154: Alter the node/N/signups/admin signup summary fieldset with per-status limit data in a second to show how nicely that works.I'm still a little sour about admin/content/signup -- I'd rather just convert that to a view and get rid of all the unholy shared form junk in here, but that's a bigger story (see #582986: Make views a required dependency and ditch non-views code for more).
Comment #3
mlsamuelson commentedPatch applies fine. The altered signup summary works as expected. It is compact, and doesn't push the signup details very far down the screen. They are still above the fold for most reasonable screen resolutions. I don't miss the table. :)
Comment #4
dwwCommitted to HEAD and DRUPAL-6--1. Thanks.