There are two new features in the permalink module

  1. #574712: Add Drupal 7.x-style permalinks to comments
  2. #578576: Allow overrides from other modules that show comments on different pages

Which allow for comment permalinks like Drupal 7 does them (i.e. comment/CID#comment-CID) and also improves on that feature to make the URL where comments are overridable.

The attached patch implements the hook in talk module to tell permalink where talk will put the comments for the node.

CommentFileSizeAuthor
hook_permalink_comment_page_talk.patch623 bytesgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Assigned: Unassigned » greggles
Status: Active » Needs review

And for what it's worth, I plan to commit this in the next few days if there's no feedback. It's fairly simple and fairly well tested.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Needs work

Actually, it's unlikely that my version of the comment permalinks will be backported so the real fix will be a hook_menu_alter that defines a new page callback that uses the right url, so this needs work.

ñull’s picture

ñull commented

+1 as far as this relates to the wrong "Recent comments" links. Or should we consider that a bug?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs work » Closed (won't fix)

@com2 - I have no idea what you're talking about :/ Please open a new issue that describes whatever it is that you feel is a bug (and provide more details).

Also, since permalink is such an uncommon module and Drupal7 doesn't provide this I think we should skip this feature.