I have repeatedly tested this and found that the multistep module when enabled on a content-type disables the working of CCK multigroup module (btw this module allows users to submit multiple values to a field-group) The CCK multigroup module is under active development under 6.x-3.x branch (not currently available as a part of cck)

I thought i should bring this to the notice of module developers, i have also submitted a request to the author of the Multigroup Module

-jayesh

CommentFileSizeAuthor
#15 multistep.patch194 bytesgarrizaldy
#9 multistep-579126-9.patch1.3 KBAnonymous (not verified)
#8 multistep-579126-1.patch1.53 KBvkareh
#7 multistep-579126.patch1.55 KBvkareh

Comments

mesh’s picture

Issue tags: +multistep, +cck-multigroup

an update

the response from the cck-multigroup issue queue - 579136: Multigroup module breaks with Multistep (#1)

smscotten’s picture

I'm encountering the same thing. The first item in the multigroup appears, then when "Add More Values" is clicked, a new row in the multigroup is created, but it is empty. Works as expected with multistep disabled for this content type (multistep module still enabled).

mesh’s picture

does not happen when the multigroup is shown on the first step, though. it seems it has to do something with form submission, redirection and AHAH (?)

mesh’s picture

and, it works for other steps if i removed the #ahah - path attribute from the 'Add more values' button (in the content_multigroup.node_form.inc). somebody with more drupal experience please explain!!

smscotten’s picture

Title: Multistep module disables working of CCK Multigroup module » Multistep module disables working of CCK Multi-value fields

Eventually one of these will have to be marked as a duplicate, but for the moment I'd like to call attention to the test setup I made and reported at #579136-13: Multigroup module breaks with Multistep that clearly shows the behavior.

http://devel.splicer.com/ is a clean install with minimal modules. It demonstrates the incompatibility between multistep and cck-multigroup. It also shows that the problem is not limited to multigroups but to all cck fields that accept more than one value.

Anonymous’s picture

Title: Multistep module disables working of CCK Multi-value fields » Multistep module breaks multi-valued fields
Version: 6.x-1.3 » 6.x-1.x-dev
Priority: Normal » Critical

I too have come across this issue (in the -dev version). Marking as critical as Multistep is unusable as long as you have multi-valued fields...

vkareh’s picture

Assigned: Unassigned » vkareh
Status: Active » Needs review
StatusFileSize
new1.55 KB

Hello guys! Took me a while to get down to this, sorry for the delay.

I realized that when the AHAH call is made, its internal URL arguments are different from those in the node edit form. The multistep module calculates the step based on the URL arguments, which meant that when you clicked on "Add another item", it was defaulting the $step of that field to 1, which in turn meant that it wasn't being shown on any step other than 1.

Anyway, I added a new condition to calculate the step for the js_add_more call and added a new function that calculates what the step should be for that specific field in the current content type.

Some things I still need to test/take into consideration:

Please test this patch and let me know your thoughts. I'll keep working on the above issues, and eventually we can decide whether this will take care of #579136: Multigroup module breaks with Multistep.

edit: I forgot to mention that I'm using CCK-6.x-2.5.

vkareh’s picture

StatusFileSize
new1.53 KB

New patch. Made it work with with Multigroups in CCK-6.x-3.x-dev (2009-Oct-05) by ignoring the first argument of the "Add another item" URL call, which dictates whether it's content or content_multigroup, and focused only on the js_add_more clause.

Also tested it with different field/widget types inside both multigroups and regular groups. It appears that as long as the widget module allows CCK to handle the multi-value, it should work (which is the same condition that allows content_multigroup to work).

Anonymous’s picture

StatusFileSize
new1.3 KB

Works for me!

I just edited the patch slightly to make it run from the multistep folder (for those with multistep installed somewhere other than sites/all...)

vkareh’s picture

Status: Needs review » Fixed

I committed the patch into the new development snapshot. Please update and use that one from now on.

Anonymous’s picture

Status: Fixed » Active

I tried updating to the new -dev version, but the problem's still there.

I did a search in multistep.module for "_multistep_get_field_step" but couldn't find anything. The CVS page says you committed the changes, but they don't seem to be appearing in the latest -dev on the project page (even though it's dated 2009-Oct-17)...

vkareh’s picture

Status: Active » Fixed

Development snapshots are updated nightly. Re-download it today, or do a checkout directly from CVS (which is updated real-time).

Look for line 576 on multistep.module:

function _multistep_get_field_step($field, $type) {
  $step = 1;
  $group = _fieldgroup_field_get_group($type, $field);
  $groups = fieldgroup_groups($type);
  $step = $groups[$group]['settings']['multistep']['step'];
  return $step;
}
Anonymous’s picture

Thanks, all's working now :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

garrizaldy’s picture

Component: User interface » Code
Priority: Critical » Normal
Status: Closed (fixed) » Patch (to be ported)
StatusFileSize
new194 bytes

re opening this bug report.

Reading #12

variable $step is being set to 1 but being overridden in the line just above the return in which if the $groups[$group]['settings']['multistep']['step']; returned a null or false the multigroup or multivalues will not display. Attaching a simple patch to check whether the groups are returning either than false

Bilmar’s picture

subscribing

vkareh’s picture

Assigned: vkareh » Unassigned
Status: Patch (to be ported) » Fixed

Thanks for the patch, garrizaldy!

Based on that, I changed the code to verify whether the group is a multi-valued field or a multigroup, and only override $step if there is a value to override.

The change is now in the latest development snapshot.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

amaisano’s picture

Priority: Normal » Critical
Status: Closed (fixed) » Active

Have the latest dev. version and still having the same problem. When "Add Another" buttons are clicked, the entire field is disappearing - both in "View Entire Form" and during the multistep process.

lelizondo’s picture

I'm also having the same problem..

lotyrin’s picture

Priority: Critical » Normal
Status: Active » Closed (fixed)
rafaelcr’s picture

I still have this issue. I noticed that it doesn't matter if the field is on step 1, it still doesn't work.
But, if I'm logged in as admin, it works on any step.
Could this be related to permissions?