Static Maps are not effectively cached

digi24 - September 17, 2009 - 00:21
Project:Google Maps Tools
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active
Description

Please correct me if I am wrong, but as far as I understand the following logic in includes is not correct:
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/gmaps/inclu...

$smi->view has to be called after the file is downloaded, otherwise, Drupal downloads a file but does not use it, as the caches were already written.

Easy to fix once you notice, splitting it up into the throttle and cache condition, but I am not sure about $smi->headers.

#1

digi24 - September 17, 2009 - 00:53

And another thing, $cache[cid] in _gmaps_static_map_item_render is not defined, cache does not get used (and google bans my ip...) :)

#2

xmarket - September 18, 2009 - 06:01

The entire caching mechanism has been reworked for maps, static maps and for gmaps_taxonomy. It will be available in the next commit.

It will fix this bug, too.

 
 

Drupal is a registered trademark of Dries Buytaert.