Download & Extend

Static Maps are not effectively cached

Project:Google Maps Tools
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:xmarket
Status:closed (fixed)

Issue Summary

Please correct me if I am wrong, but as far as I understand the following logic in includes is not correct:
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/gmaps/inclu...

$smi->view has to be called after the file is downloaded, otherwise, Drupal downloads a file but does not use it, as the caches were already written.

Easy to fix once you notice, splitting it up into the throttle and cache condition, but I am not sure about $smi->headers.

Comments

#1

And another thing, $cache[cid] in _gmaps_static_map_item_render is not defined, cache does not get used (and google bans my ip...) :)

#2

The entire caching mechanism has been reworked for maps, static maps and for gmaps_taxonomy. It will be available in the next commit.

It will fix this bug, too.

#3

Assigned to:Anonymous» xmarket
Status:active» fixed

Feel free to reopen, if you have any question.

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here