Ever since d.o was upgraded to core 6.14 today, previewing issue comments no longer works. I just tried it locally and I'm seeing the same thing. Clearly something in 6.14 changed in some way that's breaking issue comment previews. :( Ugh.
The culprit appears to be #302240: button broken due to fix various problems when using form storage . If I revert revision 1.265.2.27 of form.inc, everything works again. Joy.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 579900-8.project_issue_comment_preview.png | 75.13 KB | dww |
| #6 | 579900-6.project_issue_comment_preview_6-14-fapi.patch | 1.28 KB | dww |
| #5 | 579900-5.project_issue_comment_preview_6-14-fapi.patch | 1.28 KB | dww |
Comments
Comment #1
dwwProbably goes without saying, but this is a 6.x-1.0 blocker, too...
Comment #2
BayouBill commentedSubscribing. I've also noticed this problem recently.
Comment #3
jonathan1055 commentedSubscribing. I also hit this. At the same time, I found that file upload and attachments randomly halted at different places, eg sometimes I could upload file 3 in a series after doing 1 & 2 successfully, then on retry I could only upload the first file and it halted on file2. Is this linked to the same problem?
I mentioned it on the forum
Shouldn't this get raised to high priority? I think it is serious enough as anyone who has upgraded now has lost an important part of their sites functionality.
Jonathan
Comment #4
dwwThe comment_upload stuff isn't for this issue, that's a totally separate bug over at #441216: upload periodically hanging in Safari, Opera and perhaps others.
I just wrapped up the end of a massive deadline that was due tonight. I was just reviewing my personal todo list and bumped this issue up to my "things to work on today" list. I was hoping someone else was going to take a stab at it, but that seems to not be the case... Probably should be critical, yes. Honestly, I'm surprised there haven't been more duplicate issues posted about this in the infra and webmaster queues. ;)
Comment #5
dwwBased on a fruitful debugging session w/ DamZ, here's what we came up with. Seems to work fine on my laptop.
Comment #6
dwwFixed typo in the code comment. #302240: button broken due to fix various problems when using form storage does look like a 6.14 FAPI regression, but meanwhile, we should probably still commit this.
Comment #7
hunmonk commentedthis looks like the best we can do given the regression, and i think it can safely stay in for good. tested, and if does indeed fix the problem. ship it!
Comment #8
dwwCommitted to HEAD, merged into SVN, deployed on d.o, and working. ;) I'm previewing this now. Yay!
Comment #9
pasqualleThe preview is broken on group.drupal.org site also. Could it be the same problem?
Comment #10
dww@Pasqualle: I noticed that, but what's strange is that in that case, it's broken even for core comment previews on regular CCK content types there. Yes, it's certainly possible it's somehow related to #302240: button broken due to fix various problems when using form storage , but this patch and this issue won't help g.d.o. If someone wants to investigate exactly what's going wrong on g.d.o and try to come up with a work-around, they could. An obvious something to try would be:
just to see if that works. I'm not sure if g.d.o comments are expecting a form rebuild or not, and if so, why, etc. Probably we should open a separate infra issue in the g.d.o component about this.
Comment #11
toemaz commentedI have this problem as well for previewing comments on all nodes and it's introduced after the upgrade to D6.14. Upgrading project & project tracker didn't solve it, so I tried the trick provided by dww:
This solved it for me and so I presume it will solve the problem on g.d.o as well.