I spotted what seems like an oddity in the way the hierarchy field in the vocabulary table behaves: see http://drupal.org/node/383926#comment-2026102:

Testing on a nearly-vanilla Drupal 6.13 sandbox:

(1) Create vocab: not tagging; not multiple; required. Result: hierarchy field = 0.
(2) Add a parent term then a child term. Result: hierarchy field = 1.
(3) Edit & save vocab with no changes. Result: hierarchy field = 0.
(4) Add another child term. Result: hierarchy field = 1.

Does (3) represent a bug in taxonomy.module? Or is the hierarchy field no longer used in any consistent way in D6?

Dave

CommentFileSizeAuthor
#5 taxonomy-hierarchy-580040.patch1.08 KBrsoden
#1 taxonomy-hierarchy-580040.patch1.08 KBrsoden

Comments

rsoden’s picture

rsoden commented
Status: Active » Needs review
StatusFileSize
new taxonomy-hierarchy-580040.patch1.08 KB

The same behavior is happening with term relations. Attached is a patch that fixes both by using values from the $edit array - which are set to appropriate defaults but won't override values that are already set.

Status: Needs review » Needs work

The last submitted patch, taxonomy-hierarchy-580040.patch, failed testing.

yhahn’s picture

yhahn commented

Subscribing.

tmcw’s picture

tmcw commented

+1

rsoden’s picture

rsoden commented
Version: 6.13 » 6.17
StatusFileSize
new taxonomy-hierarchy-580040.patch1.08 KB

Updating version, reattaching patch.

rsoden’s picture

rsoden commented
Status: Needs work » Needs review

Needs review.

Status: Needs review » Needs work

The last submitted patch, taxonomy-hierarchy-580040.patch, failed testing.

jonathan_hunt’s picture

jonathan_hunt commented

Patch works for me. Would be good to see it committed.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Needs work » Closed (duplicate)

#353775: Vocabulary edit form resets the 'hierarchy' (D7) field to '0' and 'relations' field (D6) to '1' is now further along.