Hi,

I've trye to build a slide form a view containing imagecache images, but it shows only original images.
I've looked at the views_slideshow_ddblock_add_image function in views_slideshow_ddblock.module and found some stranges things.

First, I think that we must replace "$vars['ddblock_pager_settings']" and "$vars['ddblock_slider_settings']" by "$vars['views_slideshow_ddblock_pager_settings']" and "$vars['views_slideshow_ddblock_slider_settings']"

But even if the "Use imagecache presets" checkbox is checked, I get an empty $vars['views_slideshow_ddblock_slider_settings']['imgcache_toggle'] value in the views_slideshow_ddblock_add_image function

(by the way, the $vars value is realy huge ! )

CommentFileSizeAuthor
#2 fix-image-cache-580204-2.patch2.81 KBppblaauw
#3 fix-image-cache-580204-3.patch2.78 KBppblaauw

Comments

Anonymous’s picture

Anonymous (not verified) commented

I think I've found the cause of the problem

In the views_slideshow_ddblock.theme.inc file, line 90, I had to replace

$vars['views_slideshow_ddblock_slider_settings']['imgcache_toggle']     = $options['imgcache']['imgcache_toggle'];

by

$vars['views_slideshow_ddblock_slider_settings']['imgcache_toggle']     = $options['imgcache_toggle'];
ppblaauw’s picture

ppblaauw commented
StatusFileSize
new fix-image-cache-580204-2.patch2.81 KB

Thank you for finding and posting this bug

Attached is a patch to fix the image cache presets not used issue

Edit:new patch, see #3

ppblaauw’s picture

ppblaauw commented
Status: Active » Needs review
StatusFileSize
new fix-image-cache-580204-3.patch2.78 KB

Still an issue found
attached a new patch

introfini’s picture

introfini commented

I've tested it and it works.

Thanks :-)

ppblaauw’s picture

ppblaauw commented
Status: Needs review » Reviewed & tested by the community

Thanks for testing
Will be committed in next dev release

ppblaauw’s picture

ppblaauw commented
Status: Reviewed & tested by the community » Fixed

Committed to next dev release 18-OCT-2009

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.