Closed (fixed)
Project:
Insert
Version:
6.x-1.0-beta4
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Sep 2009 at 14:18 UTC
Updated:
31 Aug 2011 at 12:23 UTC
Jump to comment: Most recent file
Comments
Comment #1
that0n3guy commentedMaybe I should be posting this in the wysiwyg issues... but...
here is the patch for support for IMCE bridge with ckeditor, I figured it would help: http://drupal.org/node/533168#comment-2052198
Comment #2
michelleI'm waiting for this as well. I currently use BUEditor and have a historic dislike for WYSIWYGs but Filefield Insert looks awesome and I'm willing to use a WYSIWYG for it... But I'd rather switch right to CKEditor if possible because that one looks pretty decent.
Michelle
Comment #3
quicksketchMoving to Insert module.
Comment #4
quicksketchI've committed this patch which provides "direct" support for CKeditor, but unfortunately I don't think this is a common use-case.
Insert should work with WYSIWYG API immediately, but I found a few bugs in the CKeditor implementation that need fixing in the WYSIWYG queue:
#610132: CKEditor 3.0.1, stylesheets and version check.
#610858: Focus Event not Firing for CKeditor
And just a general annoyance:
#610874: Drupal.wysiwyg.activeId should default to first editor, not last
If you want to use CKeditor with Insert, I'd recommend using WYSIWYG module, then applying the above patches which will make it so Insert can use WYSIWYG API properly.
Comment #5
michellequicksketch, you are awesome! I'm going to be porting my site to Drupal 6 Halloween weekend and will hopefully be able to have this in place when it goes live. :) Will test it out on my dev site ASAP.
Michelle
Comment #6
plebe commentedNate rocking Le House! I panicked when I saw that FileField Insert disappeared. Insert rules!
Comment #7
bg1 commentedI am confused because I see references to WYSIWYG API in conjunction with CKEditor. I have CKEditor installed, but it was my impression that one should not use WYSIWYG in conjunction with FCKEditor or CKEditor.
I have the CKEditor module in folder drupal/sites/all/modules and the actual CKEditor in drupal/sites/all/modules/ckeditor/ckeditor/ckeditor.
CKEditor seems to be working fine, but I have not figured out how my non-technical content managers can embed images in their content body.
Any suggestions or clarification vis-a-vis WYSIWYG and CKEditor?
Thanks in advance.
Comment #8
quicksketchWYSIWYG module works better with CKeditor than the CKeditor module does (in my opinion). You should use the WYSIWYG module regardless of what editor you are actually using, since it's the only system that properly ties WYSIWYGs to Drupal Input Formats. Every other system will do ridiculous things like put a WYSIWYG editor on PHP fields.
However, Insert should still be made to work with CKeditor (the module) directly, even though its functionality is more limited than when utilizing the WYSIWYG module. Right now Insert will not work with CKeditor module, because it's so new and didn't actually exist when the first set of patches was applied from this issue.
Comment #9
michelleActually, I had WYSIWYG, Insert, and CKEditor all working together about a month ago. I can't remember if I needed to apply any patches from the queue but it worked. Unfortunately, I had to abandon WYSIWYG because it doesn't work with javascript from Quote or Smileys. :( So I don't know if it continues to work but it worked back then.
Michelle
Comment #10
quicksketchThis is already done per #4.
Comment #12
Geijutsuka commentedSorry to reopen this wound, but there are apparently more kinks which need to be worked out between CKeditor and Insert.
My supervisor and I finally settled on the CKeditor (we wouldn't have an editor at all if we could get away with it!), but we also abandoned the WYSIWYG module because it limited the customization of the editor.
Anyway, Insert works perfectly—and I mean perfectly—with a regular Drupal page (Drupal 6.16), but when I made my own custom content type, the insert module failed to get through CKeditor's barriers. I disabled the editor by clicking on the toggle link below the text area to disable/enable rich text editing, then I inserted the image (showed up in HTML, of course) and then re-enabled CKeditor. It worked: disable—insert image—enable. Then I was able to do whatever I wanted with it in the properties.
I tested this on three sites and all had the same results (one of the sites being a brand-spankin-new install). Can you confirm this glitch, and, if so, can/will it be fixed?
Again, sorry to reopen this issue, but this had to be brought to someone's attention and the information posted if anyone comes across the same issue as mine.
Note:
Oddly enough, the custom content types I made before the installation of CKeditor work just fine with CKeditor on.
Comment #13
quicksketchI'll need to know EXACT steps to reproduce this problem from a NEW Drupal install, as I am unable to reproduce the problem.
Comment #14
Geijutsuka commentedThere must be some other component responsible for this glitch. I did another new Drupal install with only the absolutely necessary modules enabled—carefully documenting my steps along the way—and I cannot replicate the problem. If I find out the culprit (which is obviously not Insert) I will make note of it in the correct queue. Sorry for the hasty conclusion; compatibility issues between Insert and CKeditor are indeed fixed.
Comment #15
Geijutsuka commentedOk. I'm leaving the status as fixed unless anyone else can confirm this: I've been working on this all day and finally figured out the exact settings which make the problem. CKEditor will not let the Insert module put an image into a custom text area. In a new content type, I took away the default body field (by removing the label) and put in a custom CCK text area. This completely new Drupal site was installed on localhost using WAMP: Windows XP, Apache 2.2.11, MySQL 5.1.36, PHP 5.2.11. Clean URLs enabled.
Modules enabled other than Insert and CKEditor:
CKEditor settings:
Profiles
FileField/ImageField settings:
Input format: unaltered Full HTML
If no one else can get the same results, then I don't know what to say.
Comment #16
quicksketchThanks geijutsuka, appreciated for your extensive testing efforts. I believe what you've discovered is an intentional behavior in Insert. Insert has "hard-coded" support for the body field, because CKeditor itself does not provide an API for getting the active editor. However it's an excellent report and somehow it should be possible. I actually think it is already done if you use WYSIWYG module instead of CKeditor.
Comment #17
Geijutsuka commentedNo problem. Getting through that stubborn CKEditor on custom text areas would be great. Until then, I'll do the "disable/enable rich text" dance. Hope you Lullabots have fun at your super-awesome Drupalcon party!
Comment #18
atolson commentedFor what it's worth, I have run into the same issue after installing Insert today. The set up is similar to geijutsuka except that I am using CKEditor through WYSIWYG AND I have not removed the default body field. My image inserts are going directly into the default body field.
Drupal 6.16
Admin_Menu: 6.x-1.5
Views: 6.x-2.1
Panels: 6.x.3.3
Ctools 6.x.1.3
WYSIWYG 6.x-2.1
CKEditor 3.2.1
CCK 6.x-2.6
Voting API 6.x.2.3
Advanced Help 6.x-1.2
ImageField 6.x-3.2
Filefield 6.x-3.2
ImageCache 6.x-2.0
ImageAPI 6.x-1.6
Insert 6.x-1.0-beta4
CKEditor and ImageField settings default
Comment #19
quicksketchatolson, are you saying that Insert is or is not working for you?
Comment #21
atolson commentedInsert is working for me. However, I have to either toggle the rich-text editor (CKEditor) or the Input format before the image itself appears in the editor. Before toggling, I just see an icon indicating that the html for an image is there.
So yes. Insert works for me. However there is this little glitch with needing to toggle to see the image itself.
When I said "My image inserts are going directly into the default body field." I was referring to geijutsuka's comment that the problem didn't exist when inserting into the body field. geijutsuka said it was only a problem for custom fields. My experience is otherwise.
Comment #22
lukus@atolson
Insert works for me without needing the rich-text toggle workaround;
I previously had problems with ckeditor / wysiwyg module in relation to the field_collection module - toggling rich-text worked as a temporary fix. I found that this patch fixed my problem - I've a sneaking suspicion it will solve your problem too..
http://drupal.org/node/1155678
EDIT: Actually, with the patch the first image is inserted perfectly. If I try to insert a second image using a different image style, the second image is shown using the broken image link icon until the rich-text toggle workaround is performed.
Comment #23
atolson commented@lukus
Thanks for the reply.
I no longer have to toggle ckeditor. I have no idea what fixed it. At some point in the last year, it just started working. I don't recall troubleshooting it any further, but I have certaintly installed new modules, updated core/modules and changed configurations in that time.
Perhaps your suggestion will work for someone else though.