An offshoot of: http://drupal.org/node/56415

When the contact menu item is in disabled mode (as a suggested item). the contact form doesn't get a breadcrumb.

Thanks
-K

CommentFileSizeAuthor
menu_suggested_item.patch.txt1.52 KBZen

Comments

killes@www.drop.org’s picture

killes@www.drop.org commented

Anybody got sugestion on how this _should_ behave?

jonbob’s picture

jonbob commented

I'm not sure about this. My concern is that you could have

Home > foo > bar

where foo is a suggested item, and bar is a normal item. In this case, when you're viewing bar you probably don't want foo in the breadcrumb trail.

Zen’s picture

Zen commented

I'm not so sure. In your example, if bar is hierarchically under foo, then it usually follows that bar was/can be reached from foo. Considering that a breadcrumb indicates location/path, it makes sense to me that foo is displayed in the breadcrumb.

I'm not sure I can come up with a real world example of where this isn't the case.

IMO, MENU_SUGGESTED_ITEM should only decide if something is going to be visible in the navigation menu and not the breadcrumb.

Thanks
-K

Zen’s picture

Zen commented

I just tested the reverse of JonBob's example:

-I added a MENU_NORMAL_ITEM named foo at location '/foo'.
-I added a MENU_SUGGESTED_ITEM named bar at '/foo/bar'.

I visit foo and see only 'home' in the breadcrumb as expected.

I visit foo/bar and I should see 'home->foo'. But I only see 'home'. This is because 'foo' is now the last item (with bar being suppressed as a suggested item) and is considered to be the current page and therefore not displayed.

Thanks
-K

jonbob’s picture

jonbob commented

I'm still not 100% sure that the item should show up in the trail in my example, but you have me convinced that the other behavior is at least no worse. So a +0 from me. :-)

Zen’s picture

Zen commented

Additional test: when the suggested item (after applying above patch) is enabled and then disabled, the breadcrumb item disappears. A reset .. resets the behaviour.

-K

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Fixed

applied

simon rawson’s picture

simon rawson commented

Hmm... for what it's worth, I don't like this change. It means that lots of my static pages now have: Home > content ... in the breadcrumb. Of course this can be worked around.

Bit of a quick commit, this one!

Zen’s picture

Zen commented

You can enable and then disable 'content' to hide it. I personally find the presence of 'content' in my breadcrumb sensible as 'q=node' is the parent path.

A bug created by this issue however is that the front page now has a 'home' in it. I will submit a patch for this later today.

Thanks
-K

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
moshe weitzman’s picture

moshe weitzman commented
Version: » 4.7.0
Status: Closed (fixed) » Active

My humble opinion is that the suggested workaround is insane. We should not have Home AND content in such a standard breadcrumb like a node view. In every site i've seen, Home *is* the overview of all content on the site. No need for bth links. Except for those annoying flash frontpages but we aren't catering to them i think.

dww’s picture

dww
we/he/they
commented

i'm with moshe on this. having "content" in the breadcrumb is nuts. you can't navigate to these pages by way of the "node" link directly, that's definitely a special case. breadcrumbs should be valid navigational links you can use to find your way back. "content" is no such thing, and doesn't belong in the BC. i don't really have a proposal for a patch to change the behavior, but a big +1 on changing the behavior somehow.

Jaza’s picture

Jaza commented

I've written a patch to fix this problem - see http://drupal.org/node/62147 (I created a new issue, because I think that this problem is a separate issue with the individual 'node' menu item, rather than a problem with the menu system in general).

moshe weitzman’s picture

moshe weitzman commented
Status: Active » Reviewed & tested by the community

nice. finally someone who knows what they are talking about. tested and verified to fix the issue.

moshe weitzman’s picture

moshe weitzman commented
Status: Reviewed & tested by the community » Closed (fixed)

oops. i meant to post that followup in other issue. setting this back to closed since we will proceed in jaza's new issue.