FeedAPI doesnt update on cron run after drupal 6.14 upgrade

lbarrioc - September 17, 2009 - 17:41
Project:FeedAPI
Version:6.x-1.9-beta3
Component:Code feedapi (core module)
Category:support request
Priority:normal
Assigned:Unassigned
Status:active
Description

FeedAPI doesnt woks after drupal 6.14 upgrade. Aggregator module works fine, but feedapi doesnt find new items when cron runs. Feeds only refresh manually. Thanks for any help.

#1

westwesterson - September 17, 2009 - 18:08
Title:FeedAPI doesnt woks after drupal 6.14 upgrade» FeedAPI doesnt update on cron run after drupal 6.14 upgrade

I can confirm that this is a problem.

#2

yhahn - September 18, 2009 - 03:44
Priority:normal» critical

This is caused by a change in 6.14 to common.inc which clears out the max_execution_time setting of PHP when running cron:

function drupal_cron_run() {
  // Try to allocate enough time to run all the hook_cron implementations.
  if (function_exists('set_time_limit')) {
    @set_time_limit($time_limit);
  }

This is meant to make the cron max exec time unlimited, but feedapi (and other modules) that attempt calculations based on max_execution_time in order to limit their cron time usage more or less barf. For example, this change causes feedapi_cron_time() to always return 0, meaning that feedapi will no longer run.

It's not clear what the right solution is here and it is somewhat disconcerting given that several other modules make use of this PHP setting for calculations.

#3

Aron Novak - September 18, 2009 - 07:22
Status:active» fixed

In -dev, it's already fixed. However this change in core is painful.

$max_exec_time = ini_get('max_execution_time') == 0 ? 120 : ini_get('max_execution_time');

#4

alex_b - September 18, 2009 - 14:43

For the record, the issue for the fix in #3 is here: #350788-33: Feeds not refreshing on cron - until a FeedAPI 1.9 beta 1 is out, please apply the patch from there.

#5

aharown07 - September 21, 2009 - 16:49

Haven't updated to 6.14 yet and need to make sure I'm clear on what to do.
I gather that 6.14 will break FeedAPI updating, but the patch to fix that is here: http://drupal.org/node/350788#comment-1971190?

Or can I just as easily install the latest FeedAPI dev and fix it that way?

#6

westwesterson - September 21, 2009 - 17:41

No need to patch if you install the beta.
See: http://drupal.org/node/581484

#7

AaronLBorg - September 21, 2009 - 19:53

Any other issues involved with this beta?

#8

hass - September 23, 2009 - 15:22

Only to note - the patch for this core bug can be found at #193383: set_time_limit: Centralize calls and prevent warnings and errors or now in D6-DEV.

#9

tobey_p - September 23, 2009 - 15:32

Subscribing.

#10

mimpse - September 24, 2009 - 10:41

Upgrading to FeedAPI 1.9 beta worked for me too...

#11

lbarrioc - September 25, 2009 - 21:40

But where is "Promoted items" parameter in feedAPI 6.x-1.9 content types configuration?
Now the cron runs but new feed items aren't published in fronpage.
Thanks

#12

System Message - October 9, 2009 - 21:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#13

spangaroo - October 13, 2009 - 17:21
Priority:critical» normal
Status:closed» active

Sorry I don't know if it's bad etiquette to open something that's already been closed, but this was the first thing that came up in my search.

I'm up to date on all of my modules and core 6.14. My feedAPI version is 6.x-1.9-beta2.

I'm also experiencing the problem of my RSS feed of images from a Flickr group that's not updating. The core aggregator has no issue, but I have to refresh manually to receive the new images.

Excellent module overall, just curious as to what to do about this. Thank you.

#14

telcopolis - October 14, 2009 - 15:13

Same issue here. Drupal 6.14 and FEEDAPI 1.9 beta 2
Only manual, new feeds are added.
Cron does not seem to work.

#15

hass - October 14, 2009 - 17:34

#16

ianchan - October 29, 2009 - 19:37

subscribe

#17

Ether - November 16, 2009 - 15:25
Version:6.x-1.8» 6.x-1.9-beta3

How to apply the patch ?

#18

Matt V. - December 6, 2009 - 02:10

Ether, there is a handbook section on applying patches.

For what it's worth, I was still having a problem after updating to 6.x-1.9-beta3. I applied the patch linked to from comment #15 and that fixed the issue for me.

 
 

Drupal is a registered trademark of Dries Buytaert.