Full support for ckeditor and tinymce through wysiwyg-api
Niels Hackius - September 17, 2009 - 18:19
| Project: | Web File Manager |
| Version: | 6.x-2.11 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Niels Hackius |
| Status: | needs review |
Description
I extended the support for webfm_popup to work with ckeditor and tinymce (I'm not sure if tinymce maybe already worekd beforhand) when using the wysiwyg-Modul.
The wysiwyg-people are in the process of adapting ckeditor:#462146: Add editor: CKeditor
Some of the ideas/code is taken from here: #533168: Add support for CKeditor
#1
#2
appears there was an error in the last patch. Maybe someone wants to test this?
#3
anyone?
#4
I'm walking out the door right now, but I may be able to take a look tonight sometime. If not, then for sure tomorrow.
#5
Got around to test this?
#6
Patch #2 doesn't work properly.
The patching of the .info file fails (not important). The patch is successful on the .js and module file.
The popup opens and displays the webfm file browsers but ignores all file/folder permissions (allows the user to view all files and folders even if he's doesn't have permission to do so) and there is no obvious way of selecting the image for insertion.
Right-clicking a file and choosing the "past link into editor" option doesn't work.
#7
Ah interesting - thank you for taking the time and providing feedback Steven.
2 Side notes:
I was using Wysiwyg 3.x-dev: Libraries API, Chaos Tools Suite, jQuery UI 2.x, Popups API from their CVS (http://drupal.org/node/181465/cvs-instructions/HEAD)
and webfm from cvs.
also I was using Firefox 3.5
The Option "Paste link into Editor" must be removed for the popup I guess - the correct link to choose is "Send to rich text editor"
About the permission: Thats really strange since webfm_popup only includes webfm in a different way and doesn't change anything about webfm itself.
Maybe you can give a little more inside about which browser/versions of the modules you use - I will go look for the bugs then :-)
#8
I didn't have any luck before or after applying the patch, but the biggest issue is that the webfm tinymce button doesn't appear (I enabled Bold and the webfm plugins, but only Bold appears in the edit node form). Send to Rich Text Editor appears outside of the editor context, which probably shouldn't be true either (it's just going to error if you use it anywhere else, since it's not being used in a sub-window).
TinyMCE 3.2.5, WYSIWYG 6.x-2.0, WebFM Popup 6.x-2.11 in FF 3.5.3.
#9
As I mentioned above you must be using WYSIWYG 3 - I didn't mention this in the first post, because I thought it was clear because of #462146: Add editor: CKeditor - sorry about that.
So please if you use the patch:
#10
Hmm, WYSIWYG 3 doesn't have any releases and (in all likelihood) won't until D7. So, even if it works many of us won't be able to use it.
#11
Hmm, but there is a Drupal 6 Branch so maybe you still would like to give it to try. I've got WYSIWYG 3 in Production use also.
#12
There is a D6 branch, but that was started forever ago and probably won't be really done until the D7 release is finished. I wouldn't hold my breath on a good backport.
Although you could use devel in production, I try to avoid it.
Also, the usage statistics say 1400 people are using 6-3 and 28k are using 6-2. If it's reasonable to do so, 6-2 is definitely be the one to support.
#13
You are probably right - maybe you can test for tinymce over here[#591132] and we can provide a unified patch that works for both, wyswyig 2 and 3 later on.
#14
i'm very interesting in this evolution because it would be a great thing to the both modules (wysiwyg and webfm)...i'll wait for this so...http://drupal.org/node/632166
#15
I'd be interested to see this work with drupal 6 as well. I would really like to get my users to start using WebFM but I don't see it happening on a wide scale until it is integrated with wysiwyg and tinymce.