Closed (fixed)
Project:
Javascript Tools
Version:
master
Component:
Jscalendar
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
10 Apr 2006 at 13:17 UTC
Updated:
6 Jun 2006 at 21:15 UTC
Jump to comment: Most recent file
Comments
Comment #1
nedjoGood idea. This would require passing url information to the javascript (since the script can't know what folder it's installed in, and hence what the correct image path is). I'm not sure offhand what the best way to do this is. We could use a hidden form field.
Comment #2
scott_dft commentedBest thing to do in this case would be a few clever tricks with CSS. Does each 'calendar popup' button have a class name? If so, easy to hide the text, stick a background image on, change the borders so it doesn't look like a standard button at all, etc.
The image path will be held in the CSS file, no info to pass on each time a form is rendered.
Scott
Comment #3
m3avrck commentedHere's a patch to use the Tango icon.
Nedjo, I can commit this if you want :-)
Comment #4
nedjoThanks m3averck. this is better than what we have.
I think scott_dft was right, CSS might be a preferable way--less code passed to the client, and easy to override with custom images if desired.
So, please feel free to commit your patch (and add the image file). We can always come back to this and do it the CSS way later.
Comment #5
m3avrck commentedFixed in both HEAD and 4.7.
Added new icon and changed logic so CSS controls the icon and width and so forth. Also applied some simple formatting to make the input box narrower and have the icon appear on the right side of the input. Easily overriable with CSS.
Comment #6
karens commentedWorks great in Firefox, but I see no button in IE 6 (windows xp).
Comment #7
karens commentedForgot to change status.
Comment #8
m3avrck commentedHmm don't have IE6 ATM to test, only FF and Safari.
If you remove the float:right, does it appear? What if you remove the widths on the input boxes (not on the jscalendar-icon), that work?
If not, can anyone else debug this?
Comment #9
nedjoI've tweaked the CSS and js (returned the appended element to a button that's displayed as an image with CSS) and it seems to work now. Pls reopen the issue if not.
Comment #10
(not verified) commented