Closed (fixed)
Project:
Station
Version:
6.x-2.x-dev
Component:
Schedule
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Sep 2009 at 22:26 UTC
Updated:
2 Jul 2010 at 20:15 UTC
Jump to comment: Most recent file
Comments
Comment #1
drewish commentedI think I'd rather focus on the views half of it... it doesn't really seem to be used by the rest of the patch though...
Comment #2
tim.plunkettYou mean the changes made to station/schedule/views.inc?
Yeah, I just copied everything related to "current_program" and made a "next_program" version, then made appropriate changes.
I ended up not changing anything there, I guess.
I was uncertain pretty much the entire time, so if something seems arbitrary or unnecessary, it probably is.
Comment #3
drewish commentedI think you can actually do this all with the current views code. Try importing this view and playing with it:
Comment #4
tim.plunkettI'm still baffled by Views sometimes.
For example, why is it that I can use "Station schedule item: Finish" to sort by, but I can't seem to filter by "Station schedule item: Start"?
Otherwise, this code works great, except it includes the show currently on-air. Not sure how to get around that.
Comment #5
drewish commentedBecause I never finished the filter handler for that field ;) I got sort of stalled out trying to decide how the option should work. It seemed like it should have options, perhaps:
Though the first two seems like the most important options. I'll spend some time on it today and see what I can whip up. I'd really like to get a "stable" 2.x release out the door and I feel like the schedule views support is one of the last big things to do.
Comment #6
drewish commentedi've committed some other views fixes but here's a patch i'm working on to rework the start and finish handling.
Comment #7
drewish commentedThis is getting pretty close. I've broken the schedule item times up into start, finish and time range. This might break some existing views but it should be easy enough to correct.
Updated export of the demo view:
Comment #8
drewish commentedI committed the patch for the views code since I'm pretty happy with it. I do want to work on a default "now playing" block view to ship with the module (probably disabled).
Comment #9
tim.plunkettdouble post
Comment #10
tim.plunkettJust a heads up to anyone applying these patches:
I updated to HEAD, and it broke the views code from comment #3 pretty horribly.
Make sure to delete that view!
So, "Upcoming" is spelled wrong.
Also, before I go crazy trying to get it in there: what's an easy way to get the "Tune In" with links to the streams into this block?
On second review: this displays the current program. Purposeful?
Comment #11
tim.plunkettThe views code in comment #7 is perfect for current programs, this is what I came up with for next program.
Comment #12
drewish commentedIf there's only one program in the block you can just add a relation to the schedule and add its tune in link. If there's more than one it'll appear in each item (which might be what you want if you've got multiple schedules).
Comment #13
drewish commentedi think this has been addressed. if not feel free to re-open the issue.
Comment #15
daggerhart commentedI'm using the view from Comment #11, but it doesn't seem to be wrapping back around to Sunday. Just getting Thursday -> Saturday programs.
Anyone else have the same result ?
Comment #16
tim.plunkettI just realized I'm having the same problem daggerhart was talking about. I guess I just never happened to be looking at my site on a Saturday night :)
I guess this is an issue with the views code?
Comment #17
tim.plunkettNot sure if I should open another issue or not, but this needs to be revisited.
Comment #18
tim.plunkettOpened a new issue over at #843948: Next Scheduled Program Block doesn't wrap to next week.