Coder Review - Illegal offset type in _coder_review_get_default_settings [#581088]

When browsing to /admin/config/development/coder/review I was getting the warning:

    *  Warning: Illegal offset type in _coder_review_get_default_settings() (line 671 of /var/www/head/sites/all/modules/coder/coder_review/coder_review.module).
    * Notice: Array to string conversion in drupal_validate_utf8() (line 1157 of /var/www/head/includes/bootstrap.inc).
    * Warning: preg_match() expects parameter 2 to be string, array given in drupal_validate_utf8() (line 1163 of /var/www/head/includes/bootstrap.inc).

This appeared to be caused because $arg is an array and the value I think we want is $arg['args'][0]

I've attached a patch which fixes this but I'm not sure why the change to the structure of $arg has happened and whether it's permanent, I'll try to investigate more.

Comment	File	Size	Author
#1	coder_review_illegal_offset_v2.patch	870 bytes	matason
	coder_review_illegal_offset.patch	1.24 KB	matason

Comments

Comment #1

matason commented 18 September 2009 at 23:48

Status	File	Size
new	coder_review_illegal_offset_v2.patch	870 bytes

I spent some more time on this tonight and actually spotted what looks like an obvious mistake in the function coder_review_page_form signature, the attached patch changes

function coder_review_page_form($form_state, $arg = '')

function coder_review_page_form($form, $form_state, $arg = '')

Please ignore the patch submitted on the actual issue.