After a good Q&A session, the old way of splitting up boost into 2 different pages needs to go. Update any links as well.

CommentFileSizeAuthor
#12 boost-581320.1.patch1.04 KBmikeytown2
#9 boost-581320.patch17.02 KBmikeytown2
#1 boost-581320.patch11.05 KBmikeytown2

Comments

mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new boost-581320.patch11.05 KB
dbeall’s picture

dbeall commented

1st item of note: when installing boost, on status page: Boost is not enabled(or something like that). Message with link(enable it) takes me to performance page, but shouldn't this take me to Boost Settings page.

BTW: I have added all patches from this and others i can find: testing
Will report to each patch after test is done...

mikeytown2’s picture

mikeytown2 commented 
RCS file: /cvs/drupal-contrib/contributions/modules/boost/boost.install,v
       if (!BOOST_ENABLED) {
           $requirements['boost_is_enabled'] = array(
             'title'       => $t('Boost'),
-            'description' => $t('Boost is disabled. <a href="@performance">Enable</a> it.', array('@performance' => url('admin/settings/performance'))),
+            'description' => $t('Boost is disabled. <a href="@performance">Enable</a> it.', array('@performance' => url('admin/settings/performance/boost'))),
             'severity'    => REQUIREMENT_WARNING,
             'value'       => $t('Boost Disabled'),
           );

Fairly sure thats what this fixes; be sure to upload the install file.

dbeall’s picture

dbeall commented

2nd item of note:
The preemptive cache check box not available until "Enable the cron crawler" is enabled(checked and saved).
Is there a way to make the page reset automatically(not having to click save) to allow preemptive enable.

also... Should the order on the page be changed to put the crawler at the top...
reason: check mark crawler, and continue down the page.. to preemptive setting

hope i said this right.

mikeytown2’s picture

mikeytown2 commented

thats called AHAH. I should change the description text if the crawler is disabled.
#428942: AHAH update textarea for .htaccess rules on performance >> boost page. - No one likes AHAH; this has been sitting around for some time.

dbeall’s picture

dbeall commented

well, may be my FF cache messing with me, I pulled Boost completely and reinstalled...

dbeall’s picture

dbeall commented

OK, sounds good, because people will file support request as to why the check box won't work

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Needs work

Need to change descriptions of the disabled checkboxes

mikeytown2’s picture

mikeytown2 commented
Status: Needs work » Needs review
StatusFileSize
new boost-581320.patch17.02 KB
mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Fixed

committed

dbeall’s picture

dbeall commented
Status: Fixed » Needs review

applied patch, almost got lost in the patch,lol. You are right, the file is large.
Are we nit-picking or what. Food for thought, make it dummy proof.

item of note:

[ ] Enable the cron crawler
Pre-cache boosted URL's so they get cached before anyone accesses them.
Enable the crawler first and save settings to use Preemptive Cache settings.

[ ] Preemptive Cache HTML
Enable the caching of this content type to enable this checkbox
[ ] Preemptive Cache XML
Enable the caching of this content type to enable this checkbox
[ ] Preemptive Cache AJAX/JSON
Enable the caching of this content type to enable this checkbox
[ ] Crawl All URL's in the url_alias table
Enable the crawler first to enable this checkbox.

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new boost-581320.1.patch1.04 KB

Let me know if I missed something.

dbeall’s picture

dbeall commented

Sorry that took so long, I really did get lost and had to backtrack to check the file..
IRC: seen dbeall
Drupalcon: last seen lost in boost patch. good luck to him.

dbeall’s picture

dbeall commented
Status: Needs review » Reviewed & tested by the community

I don't see anything right now, I would say ship it.
Everything that can be done to stop support requests has to be good for all.

mikeytown2’s picture

mikeytown2 commented
Status: Reviewed & tested by the community » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.