Posted by flaviovs on September 18, 2009 at 2:50pm
| Project: | Video Filter |
| Version: | 6.x-2.6 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Please, use CSS selectors in the output of the filter. I'm aware of #369674: Wrap output in DIV tag, however there are so many CSS-only themes out there, and having to create a theme function/template for them is overkill.
Something like:
<object class="filtered-video left" type="application/x-shockwave-flash"...</object>For greater control of filtered videos, it would be a plus if unique classes are also defined:
<object class="filtered-video left video-youtube-1HFrmVq0Idw" type="application/x-shockwave-flash"...</object>BTW, thanks for this great module.
Comments
#1
lovely idea!
#2
Patch:
<object class="video-filter video-filter-6928356" ...>...</object>Vimeo http://vimeo.com/6928356
<object class="video-filter video-filter-5hXZxaGZ_Bo" ...>...</object>Youtube http://www.youtube.com/watch?v=5hXZxaGZ_Bo
The class "video-filter-XXXXX" is dynamic and the value is defined in the codec file for every codec.
#3
I like the approach, but I don't like adding new code to every codec. I've taken a different approach, see attached patch.
This would also move video_filter.css up from the wysiwyg folder to the module root folder, so the alignment work.
#4
I've committed this.
#5
Automatically closed -- issue fixed for 2 weeks with no activity.