Closed (fixed)
Project:
Customerror
Version:
6.x-1.1
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Sep 2009 at 16:18 UTC
Updated:
26 Apr 2010 at 23:46 UTC
When I updated to Drupal 6.14 today, this module stpped working, In fact any 404 page is going into a loop and locking up
Comments
Comment #1
kbahey commentedI have it on 6.14 too on several sites, and there are no loops. Are you using PHP in the module? If so check if that is the issue.
Comment #2
phazer commentedMore info, it is inside the php custom code. I have it going to a new page, but the drupal_goto is not working in the php
Comment #3
phazer commentedI rolled back to 6.13 and code started working again. This is something to do with drupal_goto when dealing with page not found, etc. The above php code is in my custom-error php checkbox, but I wrote a small bit of code and put it into my own module to test. I worte this small piece of code, and point the 404 error handler from drupal to run /redirect when it runs the code on a page not found, it locks up, if I replace the drupal_goto with a drupal_set_message it works. Someting changed in the 6.14 update.
function redirect() {
$path = $_REQUEST['q'];
// drupal_goto('go/'. $path);
drupal_goto("home");
}
Comment #4
phazer commentedThis is the line introduced in Common.inc that breaks the code above
if (!isset($_REQUEST['destination'])) {
$_REQUEST['destination'] = $_GET['q'];
}
Comment #5
phazer commentedI have fixed this by altering the way I handle the request
Comment #7
seanberto commentedCould you share your code?