When I updated to Drupal 6.14 today, this module stpped working, In fact any 404 page is going into a loop and locking up

Comments

kbahey’s picture

Status: Active » Postponed (maintainer needs more info)

I have it on 6.14 too on several sites, and there are no loops. Are you using PHP in the module? If so check if that is the issue.

phazer’s picture

Status: Postponed (maintainer needs more info) » Active

More info, it is inside the php custom code. I have it going to a new page, but the drupal_goto is not working in the php


// check that the search module exists and the user has permission to hit the form
  // cool! - customerror doesn't trash the page request and the full path is available
 // $path = $_REQUEST['q'];
 // drupal_goto('go/'. $path);
drupal_set_message('home');  // works
drupal_goto("home"); //locks up
phazer’s picture

I rolled back to 6.13 and code started working again. This is something to do with drupal_goto when dealing with page not found, etc. The above php code is in my custom-error php checkbox, but I wrote a small bit of code and put it into my own module to test. I worte this small piece of code, and point the 404 error handler from drupal to run /redirect when it runs the code on a page not found, it locks up, if I replace the drupal_goto with a drupal_set_message it works. Someting changed in the 6.14 update.

function redirect() {
$path = $_REQUEST['q'];
// drupal_goto('go/'. $path);
drupal_goto("home");

}

phazer’s picture

This is the line introduced in Common.inc that breaks the code above

if (!isset($_REQUEST['destination'])) {
$_REQUEST['destination'] = $_GET['q'];
}

phazer’s picture

Status: Active » Fixed

I have fixed this by altering the way I handle the request

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

seanberto’s picture

Could you share your code?