Commit 263684 introduced a bug with the formatting of pubDate, dc:creator and guid.

Current wrong output:

<pubDate> <key>pubDate</key>  <value>Fri, 18 Sep 2009 09:19:52 -0400</value> </pubDate> 
<dc:creator> <key>dc:creator</key> <value>xxx</value> </dc:creator> 
<guid> <key>guid</key> <attributes> <isPermaLink>false</isPermaLink> </attributes> <value>xxx</value> </guid>

Old good output:

<pubDate>Fri, 18 Sep 2009 13:19:52 +0000</pubDate> 
<dc:creator>xxx</dc:creator> 
<guid isPermaLink="false">xxx</guid>

Direct diff link:
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/commentrss/...

CommentFileSizeAuthor
#3 comentrss_commentrss_format_items.patch2.2 KBfrjo

Comments

toemaz’s picture

toemaz commented
Status: Active » Needs work

Quickest solution: change line 210 in commentrss.pages.inc

from 

$items .= format_rss_item($comment->subject, $link, $content, $extra);

to

$items .= format_rss_item($comment->subject, $link, $content, array_values($extra));

Tested on production website and it works.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Fixed

Fixed the $extra array itself. Committed to CVS in http://drupal.org/cvs?commit=264592. Thanks!

frjo’s picture

frjo commented
Status: Fixed » Needs review
StatusFileSize
new comentrss_commentrss_format_items.patch2.2 KB

The committed fix is not working as far as I can see. The isPermaLink atribute is e.g. never set on"guid".

My patch reverts the code to pre 6.x-2.2 and it's also the same way node module in core build the $extra values.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

It was working better, but thanks for following up that it wasn't working completely. It seems the array passed into format_rss_item can't use string keys, so I just changed it back using the relevant parts of the rollback patch in #3. I double-confirmed that it's working properly now. Sorry about that. Going to make a new release soon once a few more module code re-organizations happen.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.