minor db_query() fix to search for DB TNG [#581594]

Comment	File	Size	Author
#4	581594.patch	2.5 KB	douggreen
#2	581594.patch	1.5 KB	douggreen
	search-dbtng.patch	1.18 KB	douggreen

Comment #1

dries commented 19 September 2009 at 10:44

Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Needs tests

I committed this to CVS HEAD. Thanks Doug.

However, it illustrated that we don't have good enough test coverage yet for search module. So I'm marking this 'code needs works', and I've added a tag.

Log in or register to post comments

Comment #2

douggreen commented 20 September 2009 at 12:16

Status:	Needs work	» Needs review
Issue tags:	-Needs tests	+Simpletest

Status	File	Size
new	581594.patch	1.5 KB

Here's a simple first cut at a test. This test would of caught this problem, ... but not too much more. It makes sure that the config settings for renders, and that the re-index button works.

Log in or register to post comments

Comment #3

douggreen commented 20 September 2009 at 12:40

Status:

Needs review

» Needs work

Needs additional work to test for #569084: Search reset module_invoke_all() issue... I'm working on it.

Log in or register to post comments

Comment #4

douggreen commented 20 September 2009 at 15:38

Status:

Needs work

» Needs review

Status	File	Size
new	581594.patch	2.5 KB

Note, that this also tests for #569536: Search links cause many nodes to be indexed twice and #569084: Search reset module_invoke_all(). Since the first patch isn't committed yet, I've included it here, otherwise, the automated testing system would reject this patch.