skinr disable the active theme

Hi darkoba,

Glad you like the module.

I've noticed this happen myself, and blamed Skinr at first too, but as it turned out it was related to a different contrib module. In my case the culprit was the dev version of the menu block module (which I shouldn't have been using in the first place). Switching to the recommended version, and reinstalling it fixed this for me.

So, my questions are:

- What contributed modules are you using?
- Are you using the latest dev version of Skinr?

:)

Jacine,

I've been tracking down the same issue in our Acquia Prosper queue #570624: Theme becomes spontaneously disabled. Basically, after some period of time, one or both of fusion core and acquia prosper are being disabled ($theme->status = 0), though acquia prosper remains the default theme.

I replicated the problem by running a Javascript location.reload() to repeatedly refresh the page. After a minute or so of refreshes, either or both of the fusion core base theme and acquia prosper sub-theme became disabled.

I assumed it was something in our theme, but hadn't been able to pin it down.

But, on a hunch, I disabled the Skinr module and the themes didn't disable themselves anymore.

I'm not running the menu block module at all, and I disabled any dev-version modules that I had, but still the only thing that stopped the themes from disabling themselves was disabling Skinr.

Is there anything in Skinr that might trigger a theme disable?

Let me know if there's any more information I can provide. I'll also ask the folks in my queue to see if they experience the same thing.

Thanks.

OK, found the culprit.
When calling system_theme_data() to grab all the theme info, there's a problem where all themes get disabled when running update.php. If we call _system_theme_data() instead, the problem is solved. It's also more efficient. The only annoyance is that it's a supposed to be a private function... oh well.

Jacine should have this updated in CVS shortly.

Committed! Thanks guys ;)

Jacine, Bala,

In my testing, that fix seems to do the trick!

Thanks for the great work :)

Awesome, glad you got it fixed! I've been trying to work on an AF style and it's a real pain to have skinr keep crashing AF. This will make my life much easier. :)

Michelle

I'm having the same issue and I'm testing the patch on #632080: _system_theme_data() should clone the returned objects. to see if it helps.

First off, skinr is incredible, and I can't thank you enough!

I am not sure if this is related or if I should be submitting a new issue, but I have a drupal commons site running with skinr 6.x.1.5 as the version packaged with the platform in Aegir. I have alot of skinr styles, and everything was working great until I got to a point where if I add any more to the .info file the theme breaks. It is very strange, it doesn't matter what I try to add, it could be anything. It has the same behavior as viewing a theme in ie without the style sheet limit fix enabled in fusion. If anyone could assist I would be more than happy to pay. I have a tight deadline and am in a crunch now.

If I should be submitting a new issue, please let me know.

Thank you again,

Jen

Thanks for the bug report Jen, can you attach or post your .info (to pastebin or similar) that is causing the problem? Can you also post a version that is working for you?

Sure. I know all I have is way overkill and is very specific, but I compiled it to use for working with clients and being able to change things on the fly as they review a site, such as "can you change that color here?", "could the title be moved a bit over and the font bigger?". I also have styles set for semantic views classes I use(vtitle, vcontent, and vusername), just to make the targeting easier. I am not a css guru or skinr expert, so be gentle:). I would like to use skinr 2, but can't with commons right now. I am attaching two files: cttcommons.info(which works, I downsized it) and infobackup.info which has just a concoction of styles to copy/paste in it, and would like to add more. I can also give you access to the site if you like, just email me.

Also, I made a copy of the acquia commons fusion-based theme(changed everything according to the documentation a drupalcommons), so it is an individual fusion subtheme, not a "subtheme of a subtheme".

Thank you for your help on this, and any feedback or best practices suggestions are more than welcome.

subscribing

FYI: Closed issues do not show up on the project issue queue's normal view. If this is still an active issue, you might want to make it active. I just happened to notice it in my tracker.

Michelle

@Michelle is right, this is closed and will not be looked at by us.

Also, this is a Drupal core bug, not a Skinr bug. If you want to follow or help fix it, you should watch this issue:

#305653: Themes disabled during update