Part of the signup limits design spec I wrote (and posted over at #359412-3: Move code for signup limits per status per node into a submodule) calls for a schema and API change to the signup.module so that the {signup_log} table would get a "count_towards_limit" column, and various parts in the signup code that interact with the global signup limit would consider this field. See the spec for details, (pages 2-3 in particular).

If we do it right, this will also give us a really good way to solve #45248: Ability to signup for a friend since we can just have this column store an int, not just a bool, which includes the # of seats each signup should consume. So, if I signup as "dww + 3 guests" for a given node, the record in {signup_log} for that signup would include "4" in the count_towards_limit column.

Opening an issue here in the signup queue to track progress on this and the related code changes...

CommentFileSizeAuthor
#4 581652-4.signup_count_towards_limit.patch8.21 KBdww
#1 581652-1.signup_count_towards_limit.patch6.97 KBdww

Comments

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new 581652-1.signup_count_towards_limit.patch6.97 KB

Initial patch that handles points #1, #2, #3, #6, and sort of addresses #4 from pages 2-3 of the signup limits design spec. #4 should really be revisited after #578592: Cleanup + fix the "Signup summary" at the top of node/N/signups/admin lands. #5 is a bit of a can of worms -- that whole site-wide signup admin page sucks.

dww’s picture

dww
we/he/they
commented

FYI: see #581826: Fix status "modify signup count" code to actually do something for using this new code (in conjunction with hook_signup_data_alter() from #581734: Improve the signup API: add hook_signup_data_alter(), hook_signup_create(), and hook_signup_update()) to fix the bug in signup_status...

dww’s picture

dww
we/he/they
commented
Status: Needs review » Postponed

Committed to HEAD and DRUPAL-6--1.

Would set this back to active for points 4 (the signup summary at the top of node/N/signups/admin) and 5 (the site-wide signup admin page at admin/content/signup), but it's really blocked on #578592: Cleanup + fix the "Signup summary" at the top of node/N/signups/admin next...

dww’s picture

dww
we/he/they
commented
StatusFileSize
new 581652-4.signup_count_towards_limit.patch8.21 KB

(FYI, the actual patch I committed was a bit different from #1... attached here for reference).

tborrome’s picture

tborrome commented

hi, i'd like to try out the functionality to signup multiple people (number of seats) .. is this available in the a dev release of the module? i dont see any dev releases from the module's releases.

dww’s picture

dww
we/he/they
commented
Status: Postponed » Fixed

Point 4 from the spec was fixed over at #578592-2: Cleanup + fix the "Signup summary" at the top of node/N/signups/admin. The only lingering issue here is admin/content/signup, but that's a bigger can of worms. Moved that whole mess to #583196: Fix the admin/content/signup administration overview page to better handle signup limits and not suck so much. Going to call this fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.