Hi,

using the latest 6.* version on a fresh install of XAMPP and Drupal 6.14 I got a PHP warning about securepages_link_alter's 2nd argument expecting a reference but getting a value.

I took the '&' out before the 2nd argument in the function definition (in agreement with the api spec for hook_link_alter), in securepages.module. problem fixed.

cheers.

CommentFileSizeAuthor
#8 securepages-php5.3-582234-8.patch633 bytesakanouras
#3 securepages_582234.patch410 bytesjantoine

Comments

webb_k’s picture

webb_k commented

Thank you. This solved the issue I had with Drupal 6.15, SecurePages 6.x-1.8, and Snow Leopard Server with MySQL 5.0.82 and PHP 5.3.0.

Anonymous’s picture

Anonymous (not verified) commented

Agreed.

@Gordon

Shall we get this committed to the development branch later today?

http://api.drupal.org/api/function/hook_link_alter

Best,
Paul Booker
Appcoast

jantoine’s picture

jantoine commented
StatusFileSize
new securepages_582234.patch410 bytes

I have cleaned up the patch from #664330: Support PHP 5.3, a duplicate of this issue. Please review and mark RTBC so we can get this fix applied.

Cheers,

Antoine

muhleder’s picture

muhleder commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, $node isn't being altered so shouldn't change any behaviour if it's not passed as a reference.

James Andres’s picture

James Andres commented

+1 subscribing

Volx’s picture

Volx commented

Patch works, thanks.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Title: hook_link_alter warning » hook_link_alter warning (PHP 5.3 compatibility)

patch works fine.

akanouras’s picture

akanouras commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new securepages-php5.3-582234-8.patch633 bytes

Hello,

the same problem appears when clicking "Add another" on a node edit form with filefields.
Attaching a patch that takes care of that as well.

Thanks,
Antonio

akanouras’s picture

akanouras commented
Title: hook_link_alter warning (PHP 5.3 compatibility) » hook_link_alter & hook_form_alter warning (PHP 5.3 compatibility)

Retitling.

akanouras’s picture

akanouras commented
Assigned: joehudson » Unassigned
Issue tags: +php5.3

Deassigning as joehudson seems to have moved past this.

grendzy’s picture

grendzy commented
Status: Needs review » Closed (duplicate)

fixed in #600106: Parameters passed by value instead of reference