Posted by GiorgosK on September 20, 2009 at 9:53am
| Project: | Vote Up/Down |
| Version: | 6.x-2.0-beta2 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (duplicate) |
| Issue tags: | vud-2-blocker |
Issue Summary
following warnings appear when installing the vote up/down term
Warning: Call-time pass-by-reference has been deprecated in \sites\all\modules\vote_up_down\vud_term\vud_term.module on line 82
Warning: Call-time pass-by-reference has been deprecated in \sites\all\modules\vote_up_down\vud_term\vud_term.module on line 87
Comments
#1
created a patch that solves this (warnings dissapear after applying)
#2
there's a node attribute assign here:
<?php$node->content['vud_term_show_table'] = array(
'#value' => theme('table', $header, $rows, $attributes = array('class' => 'vud-term-table', 'id' => "term-table-$node->nid")),
'#weight' => 0,
);
?>
so, we could change
_vud_term_generate_table()to return a$vud_term_show_tablevalue and assign it to node from outside, but I do not know all the places this function is used, so I only propose it now :-p#3
adding tag
#4
I couldn't reproduce this problem in the current dev version of the module. Was this problem already fixed?
#5
The patch in #1 is incorrect - removing the & from the function-calls is correct, but not from the function declaration itself. See updated patch (which doesn't change the style, just the implementation).
#6
Right, I agree with lyricnz on this. Committed!
#7
Automatically closed -- issue fixed for 2 weeks with no activity.
#8
Having this issue with beta2
#9
Duplicate of #841080: Warning: Call-time pass-by-reference has been deprecated
(the actual code referred to in this issue is long since fixed, but it popped up again elsewhere)