Visibility logic for "Signup: Node: Signup link" views field is wrong

dww - September 20, 2009 - 10:41
Project:Signup
Version:6.x-1.x-dev
Component:Views integration
Category:bug report
Priority:normal
Assigned:dww
Status:closed
Description

Regardless of what signup link you try to use, it appears to only provide a link when signups are open on a node. The logic for if the link should appear or not is different for each subtab:

add: only if signups are open
admin: any signup-enabled node
broadcast: only if there are signups, but regardless of open/closed
list: any signup-enabled node
settings: any signup-enabled node (see #578502-5: Move signup-related settings from node/N/edit to node/N/signups/settings)

#1

dww - September 20, 2009 - 16:59
Status:active» needs review

Simple fix. The handler was setting things up such that _signup_menu_access() thought signups were disabled when they were just closed.

AttachmentSize
582626-1.signup_views_node_signup_link_visibility.patch 1003 bytes

#2

dww - September 20, 2009 - 22:39

Here's a view that'll show off the bug if you have a site with some nodes where signups are open and others where they're closed...

AttachmentSize
582626-2.signup_admin_overview.view_.php_.txt 5.44 KB

#3

mlsamuelson - September 20, 2009 - 22:56
Status:needs review» reviewed & tested by the community

Applied the patch. It fixes the behavior. I see operations for all my signup nodes regardless of if the signups are open or closed.

#4

dww - September 20, 2009 - 23:10
Status:reviewed & tested by the community» fixed

Committed to HEAD and DRUPAL-6--1. Thanks!

#5

System Message - October 4, 2009 - 23:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.