error when $log_msg['user']->uid is empty

Dave, I am quite sure that the problem with the empty object (and resulting php error) is not caused by your module. So all that I am proposing are two small if clauses that alternatively fill the field with some debug information. After all, its the modules purpose to handle situations when other modules fail.

I am just not so fluid with the objects, so I wanted to first observe that my clauses correctly handle the error that occurs only sporadically. Generally logging, also for cron and anonymous users works fine.

Hello Dave,

you are right, the global user object should be intact, but you never know. In my case I experienced, that the global $user was set to scalar "0" (not the ->uid). I have included my modification to help other users debugging, I do not suggest it should be committed.

But where I had problems and what I think should be ammended is the way $log_msg['user']->uid and $log_msg['user']->name are accessed. As far as I understand, whenever $log_msg['user']->uid is destroyed by some other error, the logging module itself throws an error and does not email the original error message.

I am not too familiar with objects and classes, so feel free to close the issue in case I am writing total nonsense.

Hello Dave,

sorry to bother you, but I would like to ask you to at least include the is_object check or similar.

The reason is simple:
It will not be typically noticed otherwise if such an error occurs. In my view this module should always send an email if an error occurs, even if its content might not be helpful or complete.

The whole point about the issue was that it did not "pop up".

Without testing, just Copy and paste from my patch above:

$uid=NULL;
$name=NULL;
if(is_object($log_msg['user'])){
   if(isset($log_msg['user']->uid)){
      $uid = $log_msg['user']->uid;
   }
  if(isset($log_msg['user']->name)){
      $name = $log_msg['user']->name;
    }
}

...
   $message = t($message, array(
     '@base_url'      => $base_url,
     '@severity'      => $log_msg['severity'],
@@ -128,8 +152,8 @@
     '@ip'            => $log_msg['ip'],
     '@request_uri'   => $log_msg['request_uri'],
     '@referer_uri'   => $log_msg['referer'],
-    '@uid'           => $log_msg['user']->uid,
-    '@name'          => $log_msg['user']->name,
+    '@uid'           => $uid,
+    '@name'          => $name,
     '@link'          => strip_tags($log_msg['link']),
     '@message'       => strip_tags($msg),
   ));