Add latest SimpleTest backport directly to core

Did you apply the patch included with the module to Drupal core (as per the install.txt)?

I don't see why it couldn't be put into core. It doesn't change any APIs, it only adds necessary ones for SimpleTest to work. We already have D6. core additions to drupal_http_request() to help SimpleTest. Moving this to the D6 queue for review.

I guess the only problem would be if any of there are any PHP4 incompatibilities that would prevent the files from being parsed. It would need manual testing on PHP 4 to make sure Drupal 6 installs and works as normal without the SimpleTest module enabled.

Found a problem with drupal_http_request() and the latest SimpleTest backport. This really needs to land in core or testing in contrib is broken again.

Had some extra stuff left in the last patch.

This patch is what simpletest 6.x-2.x currently contains which is updated the drupal_http_request() user-agent code and optimizes some d6 logic from my original patch.

If this is committed I can remove this rather ugly step from simpletest INSTALL.txt and since we already have backported code for drupal_http_request() I agree it makes sense to: 1) update it, and 2) go the whole way and make it truly work for simpletest.

I support this patch and have already reviewed...since I made the original patch :)

As a matter of fact, I've actually tested a simpletest patched Drupal 6 on PHP 4. I've intended to test a clean D6 but had the simpletest changes applied. Unfortunately this does not work due to at least the instanceof operator being used, where parsing of common.inc halts in PHP 4 (it is only a defined operator from PHP 5).

Please do not be so light-hearted to mark a patch as RTBC even as the PHP 4 concern was raised and then not verified.

Revised patch that uses is_a() instead of instanceof

Bleh, this patch got messed up. Will work on a fresh one.

We should include hiding modules or themes that have hidden = TRUE set in their .info files as well with this backport.

We have roughly a 100 sites spread across half a dozen customers which could make good use of this patch, so we strongly support it being included in core.

Same here - the easier we can make simpletesting in Drupal 6 the more contrib modules will add tests, which would obviously be better to do before they do their Drupal 7 upgrades than after.

The patch is causing problems for me on PHP5.1

Lot's of this
Notice: Use of undefined constant E_RECOVERABLE_ERROR - assumed 'E_RECOVERABLE_ERROR' in /var/www/pre-release-01/public_html/includes/common.inc on line 3780

E_RECOVERABLE_ERROR was only introduced in 5.2

http://php.net/manual/en/errorfunc.constants.php

Maybe this can be worked around - but the patch from simpletest 6.10 doesn't work for me (apologies if I've missed something)

see also #673928: SimpleTest 6.x-2.x requires PHP 5.2, but does not require in .info

Re-rolled patch and committed to simpletest 6.x-2.x-dev

It seems this was committed as part of http://drupal.org/cvs?commit=364120. I don't know if that was on purpose though.

It shouldn't since it adds a (*ugh*) PHP5 dependency on core. The unintentional commit does have to get rolled back.

http://gophp5.org/ but oh wellz.

@bombatower: unfortunately there are people running Drupal 6 on PHP 4 and reporting critical bugs (rightly so) anytime we add code which does not run on PHP4. We offered PHP 4 support for Drupal 6, so it is how it is. BTW Dries rolled this back with #793196: rollback accidental commit with php5 code for D6, so no need to take any action here.

This might sound crazy, but is it possible to get this in as a monkey patch? As in:
<?
if(version_compare(PHP_VERSION, 5.2) && module_exists('simpletest')){
simpletest_common_inc_monkey_patch(...);
}
?>

'This would keep the noise in core to a minimum and allow simpletest specifics to be contained in simpletest module.

Not sure how this would work with bootstrap.inc ... but just an idea, trying to figure out a way to keep development and core environments in sync.

subscribing...

subscribe

subscribing

We are months later now. I tried to install simpletest and the presently included patch fails against the present D6.19. Why isn't this progressing?