Download & Extend

Users that can't edit their own signup can still toggle their status

Project:Signup Status
Version:6.x-1.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:dww
Status:closed (fixed)

Issue Summary

While testing various cases of #539052: Before clicking edit button on existing signup, only Attendance select box is disabled, I noticed that a user without perms to edit their own signup gets an enabled status selector form element, even though there's no submit button.

Comments

#1

Status:active» needs review
AttachmentSize
583010-1.signup_status_no_edit.patch 1.9 KB

#2

Status:needs review» reviewed & tested by the community

The patch fixes the behavior. A user with only Create Signups and Cancel Signups could previously toggle the status (ie. it wasn't disabled) though there was not edit/save button. After the patch, the status dropdown is disabled as desired.

#3

Status:reviewed & tested by the community» fixed

Committed to HEAD. Thanks for testing!

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#5

Status:closed (fixed)» needs work

I have a problem in Opera:
Users with permission to change their signup status can't do so in Opera.

The reason is that the fieldset is still set to disabled="disabled". In Opera this has the effect that all child elements are disabled too.

#6

Status:needs work» closed (fixed)

@donquixote: That's a separate bug from this issue. Please open a new issue for that.

#7

Here we go,
#662848: fieldset with disabled="disabled" will disable all child elements. (Signup Status, Opera)

I thought that this bug was probably introduced with the fix discussed here, but this was just a guess.

nobody click here