Closed (fixed)
Project:
Localization client
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
21 Sep 2009 at 07:59 UTC
Updated:
1 Dec 2009 at 12:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
gábor hojtsyIt definitely supported D7 at the point when it was ported. It might not support it at the moment due to the registry being rolled back and other ongoing API changes.
Comment #2
pasqualleWith this patch it seems working, but I am unsure about the dbtng changes..
Comment #3
gábor hojtsyThanks for this great patch. Reviewed, tried, fixed and committed. Corrected the following things:
- did not add the "change localization server" permission but kept relying on "administer languages" as before; don't think we need a one-off permission for just this one admin page
- admin/config/regional/translate/share was not a local task, so was not showing up; since it is still connected to language administration (from where you attempted to move out), I put it back there, but not under configure; it is now on the same level instead
- l10n_client_page_alter() did not have any arguments, &$page added
- the import form submission cleanup code lacked field definition for the lid query, also using s as a shorthand was superfluous there
This is it. Reimports, local submissions, remote submissions, etc. seem to work. Thanks again!
Comment #4
pasquallethe commit is not listed: http://drupal.org/project/cvs/140087
and the checkout does not contain the changes.
Comment #5
gábor hojtsyHaha, right. For some reason, I've had an anonymous checkout of the module. Patch attached and attempting to apply this again on a personal checkout :) Note also that I've added a todo to the import stuff to convert to an action if import/export becomes a local action, which I'd expect (but do not have time to roll a patch now).
Comment #6
gábor hojtsyOk, now sure being committed :) http://drupal.org/cvs?commit=290094 Thanks again!