system user() includes this undrupalish line: $themes = array_filter(list_themes(), create_function('$theme', 'return $theme->status;'));

I couldn't stomach that so I rewrote it to be more straightforward, I also cleaned up a little cruftiness in the theme selector code and moved that to own function (og.module duplicates same code. maybe more modules too).

CommentFileSizeAuthor
#6 theme_select_1.patch4.75 KBchx
#5 theme_select_0.patch4.7 KBchx
#4 theme_select.patch9.67 KBchx
#2 theme_selector_0.patch4.69 KBmoshe weitzman
theme_selector.patch4.23 KBmoshe weitzman

Comments

chx’s picture

chx commented
Status: Needs review » Needs work

-1, this is not the way. Use $form['foo'] = something().

moshe weitzman’s picture

moshe weitzman commented
Status: Needs work » Needs review
StatusFileSize
new theme_selector_0.patch4.69 KB

changed as per chx comment.

chx’s picture

chx commented
Status: Needs review » Needs work

First, the comment needs change, because the code returns a theme selector and not injects it (because of the change I requested). Second on the user screen this becomes the first group, which I do not like.

chx’s picture

chx commented
Status: Needs work » Needs review
StatusFileSize
new theme_select.patch9.67 KB

That's done.

chx’s picture

chx commented
StatusFileSize
new theme_select_0.patch4.7 KB
chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new theme_select_1.patch4.75 KB

Now, I moved the weight into the system_theme_select_form.

Steven’s picture

Steven commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)